Skip to content

Recognize Copilot "insufficient remaining quota" notice for review fallback - #501

Merged
maryliag merged 2 commits into
mainfrom
copilot/fix-copilot-quota-detection
Oct 28, 2026
Merged

maryliag merged 2 commits into
mainfrom
copilot/fix-copilot-quota-detection

Conversation

Copilot AI commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Recognize both Copilot quota-failure messages, including "has insufficient remaining quota," so the dashboard requests a review with the configured personal-token fallback instead of treating the failure notice as a completed review.

Keep exact matching and the Copilot-actor requirement. Add regression coverage for the new wording, completed-review exclusion, and fallback delivery with both notice variants.

Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix Copilot quota-notice detection for review fallback Recognize Copilot "insufficient remaining quota" notice for review fallback Oct 27, 2026
Copilot AI requested a review from trask October 27, 2026 14:55
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-28 13:10 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused change preserves matching safeguards and includes targeted regression coverage, with no unresolved findings.

No open issues 🎉

What changed in this PR

The dashboard now recognizes both Copilot quota-failure notices, allowing the configured personal-token fallback instead of treating the new notice as a completed review.

Changes:

  • Adds exact matching for “has insufficient remaining quota” while preserving the Copilot-actor requirement.
  • Adds regression coverage for notice recognition, completed-review exclusion, and fallback delivery with both variants.
File Description
.github/​scripts/​pull-request-dashboard/​test_copilot_review.py Adds regression tests for the new notice and fallback behavior.
.github/​scripts/​pull-request-dashboard/​copilot_review.py Recognizes both quota-failure messages through the shared predicate.

Review effort: Balanced

@trask
trask marked this pull request as ready for review October 27, 2026 16:04
@trask
trask requested a review from a team as a code owner October 27, 2026 16:04
@maryliag
maryliag merged commit 5edb00a into main Oct 28, 2026
7 checks passed
@maryliag
maryliag deleted the copilot/fix-copilot-quota-detection branch October 28, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants