Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

WebRTC Stack in Firefox 110 changed, channel.js needs changes - suggesting FIX #577

Description

@schlypel

In channel.js are 2 lines, that differentiate between encoding and parameter handling for firefox vs. other browsers.

The lines are: 312 & 339
https://github.com/open-webrtc-toolkit/owt-client-javascript/blob/main/src/sdk/conference/channel.js#L312
https://github.com/open-webrtc-toolkit/owt-client-javascript/blob/main/src/sdk/conference/channel.js#L339

This breaks functionality in Firefox 110 (update was released on Feb. 14 2023)

We fixed the issue by checking not only if it is Firefox via Utils.isFirefox() but also checking if the major version is < 110.

We have the major version in our app from some other source, owt client could use Utils.sysInfo().runtime.version.

The specific handling for Firefox seems to be not longer needed in this lines.
For us it works again now.

Untested FIX:
312| if (Utils.isFirefox() && Utils.sysInfo().runtime.version.split('.')[0] < 110) {

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions