Repository navigation
chore: enforce generated-file ownership - #4193
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 562ec0ad04
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f704f208e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Castiron-Internal-PR: openai/openai-python-internal#363 Castiron-Source-SHA: 179c8bc24778f2f018f909acb0e4d59ba7061c31 Castiron-Public-Base-SHA: 23a6be4
jbeckwith-oai
changed the title
|
Policy update in 3d0776a, following the repository owner's explicit direction: generated-file ownership relies on AGENTS.md and ordinary code review for now. Removed the proposed checksum/mode checker and its CI invocation, and updated contributor/security guidance accordingly. There is no dedicated generated-file edit gate in this rollout. The retired budget requirements are absent from the live rulesets and the old reporting workflows are disabled; normal SDK tests, security checks, CODEOWNER review and generation provenance remain. Requests to add a replacement generated-edit enforcement path are superseded by this policy decision. Monitoring the new CI head. |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed 3d0776a41c392404c5ddabdd9ae8a8e371825b92 against 23a6be4b8ab346609babc1337b445e4ee658137d, including the final removal of the proposed generated-file checker. No actionable findings after source review and an independent incremental pass.
The retired budget tooling and its consumers are removed together. The final guidance explicitly relies on contributor instructions and ordinary code review, with no dedicated generated-edit gate. Existing lint/test entry points are preserved.
Validation: current-head hosted CI has 16 successful and 9 skipped checks; still running: optional provider types (browser); no candidate code, tests or generation ran locally. I did not independently verify the author-reported live ruleset changes.
Carry the reviewed generated-file ownership guidance from merged #4193 into `next`, so contributors follow the simplified generation model before its next regeneration. All four documents exactly match main commit `1b37b9a85e857a7ada4db661bf867bf680290ccf`. They replace the retired budget instructions with the rule to change generator inputs/compiler, regenerate owned files, and keep handwritten behavior in separate extensions. Ordinary review enforces ownership; no replacement checker is introduced. This is the handwritten-documentation prerequisite only. Generated tools, inventory, generation metadata, runtime, dependencies, workflows, and release behavior are unchanged; canonical next regeneration will remove the retired generated tools separately. Validation: basic review, exact byte comparison of all four documents against the merged main commit, four-file scope assertion, and `git diff --check` pass. No runtime tests were rerun for this documentation-only change. SDK CODEOWNER review and normal next CI are required.
Automated Release PR --- ## [3.41.0](openai/openai-python@v3.40.0...v3.41.0) (2026-10-28) ### Features * **api:** accept typed references in Realtime response inputs ([openai#4189](openai#4189)) ([8ecb487](openai@8ecb487)) * **api:** add response tool usage models ([openai#4201](openai#4201)) ([55fc500](openai@55fc500)) * **api:** filter agent sessions by metadata ([openai#4200](openai#4200)) ([77fd116](openai@77fd116)) * **websocket:** recover queued binary frames after reconnect ([openai#4191](openai#4191)) ([f079868](openai@f079868)) ### Bug Fixes * **examples:** detect incomplete WebSocket responses ([openai#4187](openai#4187)) ([8559299](openai@8559299)) * **examples:** handle interruptions and disconnects in push-to-talk ([openai#4192](openai#4192)) ([35fc9f3](openai@35fc9f3)) * keep consumer fixtures clean under strict Pyright ([openai#4204](openai#4204)) ([5012565](openai@5012565)) ### Chores * **api:** document upcoming model shutdowns ([openai#4199](openai#4199)) ([5b43cce](openai@5b43cce)) * **api:** update image-model documentation ([openai#4198](openai#4198)) ([fa67521](openai@fa67521)) * enforce generated-file ownership ([openai#4193](openai#4193)) ([1b37b9a](openai@1b37b9a)) * migrate development type checking to ty ([openai#4202](openai#4202)) ([45b9531](openai@45b9531)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
Retire generated-file customization budgets and rely on
AGENTS.md, contributor guidance, and ordinary code review for ownership. Generated files must not carry handwritten edits: fix the inputs/compiler and regenerate; put custom behavior in separately owned handwritten extensions.This combines normal Castiron-regenerated cleanup with SDK-owned documentation. It removes the budget reporters, workflows, zero-only policy, and the proposed dedicated file checker. There is no dedicated generated-file edit gate for now. The compiler replaces generated output and deletes retired paths without three-way replay.
The retired budget status requirements are removed and their producers disabled across public/private SDKs. Normal SDK checks, CODEOWNER review, generation/promotion provenance, and release pins remain. Generated output and inventory changes should be reviewed together.
Validation: documentation and workflow diffs checked; the unchanged generated output still matches normal generation. Relevant formatting and focused entrypoint/layout tests pass. Two consecutive independent review rounds and current-head CI are tracked for this revision.