Skip to content

feat(api): add agent session review and tool settings - #4217

Merged
markstuart-oai merged 1 commit into
mainfrom
castiron/promotions/pr-379
Oct 31, 2026
Merged

markstuart-oai merged 1 commit into
mainfrom
castiron/promotions/pr-379

Conversation

@markstuart-oai

@markstuart-oai markstuart-oai commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds session review options and tool replacement.

Changes

  • Accept review settings when creating or updating a session.
  • Read optional session review values.
  • Replace session tools through agent.tools on session updates.

@markstuart-oai
markstuart-oai requested a review from a team as a code owner October 30, 2026 21:03
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T23:48:48.217710Z fddeb8f New commits
🔒 Security Review ✅ Completed 2026-10-30T23:49:44.411561Z fddeb8f New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@markstuart-oai
markstuart-oai force-pushed the castiron/promotions/pr-379 branch from 1f53237 to e70ff91 Compare October 30, 2026 21:06

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at e70ff91. Coordinator and independent static review found no blocking issues. The prior malformed JSON example escape finding is fixed. Session review options, nullable tool replacement and optional function async fields are consistent with the schema and serialization; internal/public changed-file blobs match. Sync/async overloads, reserved keyword aliases and generated inventory are consistent. Hosted checks completed successfully or skipped. No candidate code, tests, builds or generators ran locally.

Castiron-Promotion-ID: v1:30dc74db4b358fa53c2b4527c9808beb0f65d0b24885047ea615133c2343c8b7
@markstuart-oai
markstuart-oai force-pushed the castiron/promotions/pr-379 branch from e70ff91 to fddeb8f Compare October 30, 2026 23:47

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at fddeb8f. Coordinator and independent static review found no new issues. Stable/beta response.create forwards generate=False in both sync/async paths with matching optional event types. Narrowing close handling to Exception preserves new cancellation during cleanup; the regression checks actual task cancellation. Public also absorbs the reviewed request-local auth snapshots and function-tool async removals. Changed runtime/auth/test blobs match previously approved versions, public/internal complete trees match, and manifest hashes validate. Existing session-review/tool-update behavior remains intact. Hosted CI: {'SUCCESS': 8, 'IN_PROGRESS': 8, 'SKIPPED': 9, 'QUEUED': 1}. No candidate code or tests executed locally.

@markstuart-oai
markstuart-oai added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit a63c4cd Oct 31, 2026
26 checks passed
@markstuart-oai
markstuart-oai deleted the castiron/promotions/pr-379 branch October 31, 2026 00:05
@openai-sdks openai-sdks Bot mentioned this pull request Oct 31, 2026
gh-actions-shared Bot pushed a commit to xf-qubit/openai-python that referenced this pull request Oct 31, 2026
Automated Release PR
---


##
[3.42.0](openai/openai-python@v3.41.0...v3.42.0)
(2026-10-31)


### Features

* **api:** add agent context compaction settings
([openai#4209](openai#4209))
([f552fcf](openai@f552fcf))
* **api:** add agent session review and tool settings
([openai#4217](openai#4217))
([a63c4cd](openai@a63c4cd))
* **api:** add experimental agent time awareness
([openai#4211](openai#4211))
([10f9dd0](openai@10f9dd0))
* **api:** add image edit markup overlays
([openai#4210](openai#4210))
([72c656d](openai@72c656d))
* **api:** add organization external key management
([openai#4205](openai#4205))
([3ee373e](openai@3ee373e))
* **api:** add SIP DTMF commands and delivery events
([openai#4208](openai#4208))
([f9f3f76](openai@f9f3f76))
* **api:** improve WebSocket recovery and delivery reporting
([openai#4213](openai#4213))
([68b962c](openai@68b962c))
* **api:** keep callable API keys scoped to each request
([openai#4216](openai#4216))
([85bb536](openai@85bb536))
* **api:** support response format updates and local output types
([openai#4212](openai#4212))
([bd61e84](openai@bd61e84))
* **api:** support WebSocket warmup and preserve cleanup cancellation
([openai#4215](openai#4215))
([9abd656](openai@9abd656))


### Bug Fixes

* preserve refusal output and authentication in WebSocket helpers
([openai#4214](openai#4214))
([0599203](openai@0599203))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants