Repository navigation
test(realtime): cover typed reference input serialization - #4223
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed d9ff129 with an independent static review. The four public-path payload assertions are appropriate, but the new async case currently fails hosted CI and needs explicit peer-completion synchronization before teardown. No candidate code or tests executed locally. Python 3.10 CI remains in progress.
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Approved after static re-review of 4680764. The new threading.Event is set only after the peer validates the complete wire payload, and both sync and async paths wait for it inside the connection context. asyncio.to_thread preserves event-loop progress, and the five-second bound keeps failures finite. This addresses my prior teardown finding without weakening the payload assertions. Independent second review found no additional issues. Hosted CI is still running on this commit, including Python 3.10/3.14; no candidate code or local tests executed.
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Cover mixed existing-item references and new message inputs through synchronous and asynchronous Realtime
response.create()andsend(). Assert the complete encoded request, including the event ID, reference fields, item order, Unicode content and response settings. The explicitly typed fixture also checks the public input types at all four call sites.Validation: four local WebSocket peer cases against the qualified 3.42.1 wheel; focused type, Ruff format/lint and diff checks pass.