Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you to the editors and the WG for all the work on OpenID4VP. As an implementer, I really appreciate how the spec has evolved, and I hope this small fix helps.
The example of a Request Object passed by value in Section 5.4 has three issues:
redirect_uriClient Identifier Prefix. Section 5.9.3 states that requests using this prefix cannot be signed. This PR switches the example tox509_san_dns:client.example.org, which allows signed requests and matches the FQDN of theredirect_uri. Theclient_idin the request URL,client_id, andissin the payload are updated together, so they remain identical as required.redirect_urivalue contains a typo (https//instead ofhttps://).response_mode, which is REQUIRED per Section 5.2. Addedfragment, the default forvp_token.Editorial change to a non-normative example only. No normative text is changed.
I have signed the OpenID Foundation Contribution Agreement (DCP WG) as [Suhyeon Lee / nine01223@naver.com].