Repository navigation
Commit dc418a2
authored
fix(langchain): stop emitting space-separated provider names that price at $0 (#666)
* fix(langchain): stop emitting space-separated provider names that price at $0
Cost is resolved by lowercasing the step's `provider` and matching an
llm-costs slug exactly. Matching normalizes case but NOT separators, so a
space makes the value unmatchable and the row silently prices at zero.
Verified against the live data-stream API with identical model and token
counts:
provider="Together AI" -> cost 0.0
provider="Together_AI" -> cost 0.0065
provider="together_ai" -> cost 0.0065
Two causes, both fixed:
1. The unmapped-`ls_provider` fallback ran `.replace("_", " ").title()`,
converting values LangChain already supplies as valid slugs into
unpriceable display strings ("vercel_ai_gateway" -> "Vercel Ai Gateway").
Dropping the `.replace()` fixes every unmapped multi-token provider;
`.title()` is retained since matching is case-insensitive.
2. Six map values used literal spaces. "Together AI" -> "Together_AI" and
"Fireworks AI" -> "Fireworks_AI" in both LS_PROVIDER_TO_OPENLAYER_MAP and
LITELLM_PREFIX_TO_PROVIDER_MAP.
"Hugging Face" -> "HuggingFace" for consistency only: llm-costs publishes no
huggingface provider slug at all, so that provider remains unpriced either way.
Behavior change: `step.provider` for an unmapped `ls_provider` now keeps
underscores ("Some_New_Provider" rather than "Some New Provider"). Consumers
displaying this field verbatim will see the separator.
Adds TestProviderCostSlugs, which asserts no map value contains a space and
that known prefixes resolve to real slugs, with already-correct providers
(gemini, vertex_ai, anthropic, bedrock, deepseek) kept as regression canaries.
* test(langchain): assert provider values resolve a real cost slug
The space check catches the specific bug but not the general class: a value can
be space-free and still not price anything. Port the invariant openlayer-ts
asserts through PROVIDER_COST_SLUG -- every provider value must lowercase to a
slug published by llm-costs, or be an explicitly listed display-only vendor.
The slug set is vendored so the suite stays offline. huggingface is the sole
unpriced entry: llm-costs publishes no hugging* provider at all.
Verified red/green: against pristine main this fails with
LS_PROVIDER_TO_OPENLAYER_MAP['fireworks'] = 'Fireworks AI' lowercases to
'fireworks ai', which is neither a published cost slug nor a known-unpriced
vendor: every row would cost $01 parent e9e6ad3 commit dc418a2
2 files changed
Lines changed: 151 additions & 9 deletions
File tree
- src/openlayer/lib/integrations
- tests/lib/integrations
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
27 | 31 | | |
28 | 32 | | |
29 | 33 | | |
| |||
56 | 60 | | |
57 | 61 | | |
58 | 62 | | |
59 | | - | |
| 63 | + | |
60 | 64 | | |
61 | | - | |
| 65 | + | |
62 | 66 | | |
63 | 67 | | |
64 | | - | |
| 68 | + | |
65 | 69 | | |
66 | 70 | | |
67 | 71 | | |
| |||
77 | 81 | | |
78 | 82 | | |
79 | 83 | | |
80 | | - | |
| 84 | + | |
81 | 85 | | |
82 | | - | |
| 86 | + | |
83 | 87 | | |
84 | 88 | | |
85 | | - | |
| 89 | + | |
86 | 90 | | |
87 | 91 | | |
88 | 92 | | |
| |||
484 | 488 | | |
485 | 489 | | |
486 | 490 | | |
487 | | - | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
488 | 495 | | |
489 | 496 | | |
490 | 497 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
39 | 44 | | |
40 | 45 | | |
41 | 46 | | |
| |||
400 | 405 | | |
401 | 406 | | |
402 | 407 | | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
403 | 414 | | |
404 | 415 | | |
405 | 416 | | |
406 | 417 | | |
407 | 418 | | |
408 | 419 | | |
409 | | - | |
| 420 | + | |
410 | 421 | | |
411 | 422 | | |
412 | 423 | | |
| |||
701 | 712 | | |
702 | 713 | | |
703 | 714 | | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
0 commit comments