Skip to content

Commit 854137c

Browse files
committed
cleanup per review comments
1 parent 3fd2509 commit 854137c

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎paths_cli/compiling/engines.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
from paths_cli.compiling.plugins import EngineCompilerPlugin, CategoryPlugin
66

77
def load_openmm_xml(filename):
8-
from openpathsampling.integration_tools import HAS_OPENMM
9-
from openpathsampling.integration_tools import openmm as mm
8+
from paths_cli.compat.openmm import HAS_OPENMM, mm
109
if not HAS_OPENMM: # -no-cov-
1110
raise RuntimeError("OpenMM does not seem to be installed")
1211

‎paths_cli/tests/compiling/test_tools.py‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@ def test_custom_eval(expr, expected):
1717
def test_custom_eval_int():
1818
assert custom_eval_int('5') == 5
1919

20-
def test_custom_eval_int_strict_pos_error():
20+
@pytest.mark.parametrize('inp', [0, -1])
21+
def test_custom_eval_int_strict_pos_error(inp):
2122
with pytest.raises(InputError):
22-
custom_eval_int_strict_pos(-1)
23+
custom_eval_int_strict_pos(inp)
2324

2425
def test_mdtraj_parse_atomlist_bad_input():
2526
with pytest.raises(TypeError, match="not integers"):

0 commit comments

Comments
 (0)