Skip to content

Commit 95628c8

Browse files
committed
start to unit tests for parameters
1 parent 871ae8e commit 95628c8

2 files changed

Lines changed: 159 additions & 1 deletion

File tree

‎paths_cli/parameters.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def get(self, storage, name):
8383
return store[0]
8484

8585
# if only one is named, take it
86-
named_things = [o for o in store if o.name]
86+
named_things = [o for o in store if o.is_named]
8787
if len(named_things) == 1:
8888
return named_things[0]
8989

‎paths_cli/tests/test_parameters.py‎

Lines changed: 158 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,158 @@
1+
import pytest
2+
import tempfile
3+
import os
4+
5+
import openpathsampling as paths
6+
7+
from paths_cli.parameters import *
8+
9+
10+
class ParameterTest(object):
11+
def test_parameter(self):
12+
# this is just a smoke test to contrast with the ValueError case
13+
opt = self.Class("-f", "--foo", help="help")
14+
15+
def test_option_with_requires(self):
16+
with pytest.raises(ValueError):
17+
opt = self.Class("-f", "--foo", help="help", required=True)
18+
19+
class TestOption(ParameterTest):
20+
Class = Option
21+
22+
class TestArgument(ParameterTest):
23+
Class = Argument
24+
25+
# NOTE: all the classes defined in this are actually tested using the
26+
# instances -- we still get full coverage, and honestly, do a better job of
27+
# testing
28+
29+
class ParamInstanceTest(object):
30+
def setup(self):
31+
pes = paths.engines.toy.Gaussian(1, [1.0, 1.0], [0.0, 0.0])
32+
integ = paths.engines.toy.LangevinBAOABIntegrator(0.01, 0.1, 2.5)
33+
topology = paths.engines.toy.Topology(n_spatial=2, n_atoms=1,
34+
masses=[1.0], pes=pes)
35+
self.engine = paths.engines.toy.Engine(
36+
options={'n_frames_max': 1000, 'n_steps_per_frame': 10,
37+
'integ': integ},
38+
topology=topology
39+
).named("engine")
40+
self.other_engine = paths.engines.toy.Engine(
41+
options={'n_frames_max': 5000, 'n_steps_per_frame': 1,
42+
'integ': integ},
43+
topology=topology
44+
)
45+
self.cv = paths.FunctionCV("x", lambda x: x.xyz[0][0])
46+
self.state_A = paths.CVDefinedVolume(
47+
self.cv, float("-inf"), 0
48+
).named("A")
49+
self.state_B = paths.CVDefinedVolume(
50+
self.cv, 10, float("inf")
51+
).named("B")
52+
network = paths.TPSNetwork(self.state_A, self.state_B)
53+
self.scheme = paths.OneWayShootingMoveScheme(
54+
network,
55+
paths.UniformSelector(),
56+
self.engine
57+
).named("scheme")
58+
self.other_scheme = paths.OneWayShootingMoveScheme(
59+
network,
60+
paths.UniformSelector(),
61+
self.other_engine
62+
)
63+
self.tempdir = tempfile.mkdtemp()
64+
65+
def _filename(self, getter):
66+
return os.path.join(self.tempdir, getter + ".nc")
67+
68+
def create_file(self, getter):
69+
filename = self._filename(getter)
70+
if getter == "named":
71+
self.other_scheme = self.other_scheme.named("other")
72+
self.other_engine = self.other_engine.named("other")
73+
74+
storage = paths.Storage(filename, 'w')
75+
storage.save(self.engine)
76+
storage.save(self.cv)
77+
storage.save(self.state_A)
78+
storage.save(self.state_B)
79+
storage.save(self.scheme)
80+
81+
if getter != "only":
82+
storage.save(self.other_scheme)
83+
storage.save(self.other_engine)
84+
85+
storage.close()
86+
return filename
87+
88+
def _getter_test(self, getter):
89+
test_file = self.create_file(getter)
90+
storage = paths.Storage(self._filename(getter), mode='r')
91+
get_arg = self.get_arg[getter]
92+
obj = self.PARAMETER.get(storage, get_arg)
93+
assert obj.__uuid__ == self.obj.__uuid__
94+
assert obj == self.obj
95+
96+
def teardown(self):
97+
for temp_f in os.listdir(self.tempdir):
98+
os.remove(os.path.join(self.tempdir, temp_f))
99+
os.rmdir(self.tempdir)
100+
101+
class TestENGINE(ParamInstanceTest):
102+
PARAMETER = ENGINE
103+
def setup(self):
104+
super(TestENGINE, self).setup()
105+
self.get_arg = {'name': 'engine', 'number': 0, 'only': None,
106+
'only-named': None}
107+
self.obj = self.engine
108+
109+
@pytest.mark.parametrize("getter", ['name', 'number', 'only',
110+
'only-named'])
111+
def test_get(self, getter):
112+
self._getter_test(getter)
113+
114+
115+
class TestSCHEME(ParamInstanceTest):
116+
PARAMETER = SCHEME
117+
def setup(self):
118+
super(TestSCHEME, self).setup()
119+
self.get_arg = {'name': 'scheme', 'number': 0, 'only': None,
120+
'only-named': None}
121+
self.obj = self.scheme
122+
123+
@pytest.mark.parametrize("getter", ['name', 'number', 'only',
124+
'only-named'])
125+
def test_get(self, getter):
126+
self._getter_test(getter)
127+
128+
129+
class TestINIT_TRAJ(object):
130+
def setup(self):
131+
pytest.skip()
132+
pass
133+
134+
@pytest.mark.parametrize("getter", ['name', 'number', 'tag-final',
135+
'tag-initial', 'file'])
136+
def test_get(self, getter):
137+
pass
138+
139+
class TestCVS(ParamInstanceTest):
140+
PARAMETER = CVS
141+
def setup(self):
142+
super(TestCVS, self).setup()
143+
self.get_arg = {'name': "x", 'number': 0}
144+
self.obj = self.cv
145+
146+
@pytest.mark.parametrize("getter", ['name', 'number'])
147+
def test_get(self, getter):
148+
self._getter_test(getter)
149+
150+
class TestSTATES(object):
151+
PARAMETER = STATES
152+
def setup(self):
153+
pytest.skip()
154+
pass
155+
156+
@pytest.mark.parametrize("getter", ['name', 'number'])
157+
def test_get(self, getter):
158+
pass

0 commit comments

Comments
 (0)