Skip to content

Commit ad714d9

Browse files
committed
fix other problem with duplication
1 parent 1b6f505 commit ad714d9

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

‎paths_cli/compiling/root_compiler.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def _register_compiler_plugin(plugin):
7171
DUPLICATE_ERROR = CompilerRegistrationError(
7272
f"The name {plugin.name} has been reserved by another compiler"
7373
)
74-
if plugin.name in _COMPILERS:
74+
if plugin.name in _COMPILERS or plugin.name in _ALIASES:
7575
raise DUPLICATE_ERROR
7676

7777
compiler = _get_compiler(plugin.name)

‎paths_cli/tests/compiling/test_root_compiler.py‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ def test_register_compiler_plugin_duplicate(duplicate_of, duplicate_from):
155155

156156
# duplicate_of: existing
157157
# duplicate_from: which part of the plugin has the duplicated name
158-
pytest.skip() # FIXME: same duplication problem as before, I think
159158
if duplicate_from == 'canonical':
160159
plugin = CompilerPlugin(Mock(compiler_name=duplicate_of),
161160
aliases=['foo'])

0 commit comments

Comments
 (0)