Skip to content

Commit 3321360

Browse files
authored
Fix 26aug (#139)
* adapted anndata version. issue #137 * removed old implementations (bras and n_peaks_inconsistency) * remove shuffle integration by batch/cell type as they are not used anymore * Removed shuffle_by_batch/cell_type mentions in other files * Updated changelog
1 parent d9be010 commit 3321360

14 files changed

Lines changed: 4 additions & 632 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@
193193
* `run_benchmark`: write the commit the workflow ran from and the launch time into
194194
`task_info.yaml`, instead of publishing `_viash.yaml` verbatim (PR #136).
195195

196+
* Remove `metrics/bras` , `metrics/n_inconsitent_peaks` and `control_methods/shuffle_by_cell_type` and `control_methods/batch`
196197

197198
## BUG FIXES
198199

@@ -260,3 +261,5 @@
260261

261262

262263
* Fix check cell_type_in_both to > 0 (instead of 1) and some spelling mistakes in print.
264+
265+
* Updated anndata version to 0.12 in lisi metric to support NULL writing (PR #139)

scripts/run_benchmark/wehi_hpc/images.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ docker://ghcr.io/openproblems-bio/openproblems/utils/extract_uns_metadata:build_
22
docker://ghcr.io/openproblems-bio/task_cyto_batch_integration/control_methods/no_integration:build_setup_run_hpc
33
docker://ghcr.io/openproblems-bio/task_cyto_batch_integration/control_methods/perfect_integration:build_setup_run_hpc
44
docker://ghcr.io/openproblems-bio/task_cyto_batch_integration/control_methods/shuffle_integration_globally:build_setup_run_hpc
5-
docker://ghcr.io/openproblems-bio/task_cyto_batch_integration/control_methods/shuffle_integration_within_batch:build_setup_run_hpc
6-
docker://ghcr.io/openproblems-bio/task_cyto_batch_integration/control_methods/shuffle_integration_within_cell_type:build_setup_run_hpc
75
docker://ghcr.io/openproblems-bio/task_cyto_batch_integration/methods/batchadjust_all_controls:build_setup_run_hpc
86
docker://ghcr.io/openproblems-bio/task_cyto_batch_integration/methods/batchadjust_one_control:build_setup_run_hpc
97
docker://ghcr.io/openproblems-bio/task_cyto_batch_integration/methods/combat:build_setup_run_hpc

src/control_methods/shuffle_integration_within_batch/config.vsh.yaml

Lines changed: 0 additions & 23 deletions
This file was deleted.

src/control_methods/shuffle_integration_within_batch/script.py

Lines changed: 0 additions & 66 deletions
This file was deleted.

src/control_methods/shuffle_integration_within_cell_type/config.vsh.yaml

Lines changed: 0 additions & 24 deletions
This file was deleted.

src/control_methods/shuffle_integration_within_cell_type/script.py

Lines changed: 0 additions & 66 deletions
This file was deleted.

src/metrics/bras/config.vsh.yaml

Lines changed: 0 additions & 95 deletions
This file was deleted.

src/metrics/bras/script.py

Lines changed: 0 additions & 87 deletions
This file was deleted.

src/metrics/lisi/config.vsh.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ engines:
110110
packages:
111111
- jax~=0.6.2
112112
- jaxlib~=0.6.2
113-
- anndata~=0.11.0
113+
- anndata~=0.12.0
114114
- scanpy~=1.11.0
115115
- scib-metrics~=0.5.7
116116
- pyyaml

0 commit comments

Comments
 (0)