Skip to content

Commit 97e43ae

Browse files
authored
Write metric_ids and metric_values as lists (#130)
* write metric_ids and metric_values as lists * average_batch_r2 and flowsom_mapping_similarity wrote them as scalars * update changelog
1 parent 23c43b9 commit 97e43ae

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,3 +243,6 @@
243243

244244
* Point `scripts/run_benchmark/wehi_hpc/run_full_hpc.sh` at `build/main` instead of
245245
`build/update_ilisi`, and label the seqera full run as `full` instead of `test_subset` (PR #129).
246+
247+
* Fix `average_batch_r2` and `flowsom_mapping_similarity` writing `metric_ids` and `metric_values`
248+
as scalars instead of lists, as required by `file_score.yaml` (PR #130).

src/metrics/average_batch_r2/script.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@
8484
uns={
8585
"dataset_id": integrated_s1.uns["dataset_id"],
8686
"method_id": integrated_s1.uns["method_id"],
87-
"metric_ids": "average_batch_r2_ct",
88-
"metric_values": average_batch_r2_ct,
87+
"metric_ids": ["average_batch_r2_ct"],
88+
"metric_values": [average_batch_r2_ct],
8989
"r2_collection_ct": r2_collection_ct,
9090
}
9191
)

src/metrics/flowsom_mapping_similarity/script.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,8 @@ output <- anndata::AnnData(
144144
uns = list(
145145
dataset_id = integrated_s1$uns$dataset_id,
146146
method_id = integrated_s1$uns$method_id,
147-
metric_ids = "flowsom_mean_mapping_similarity",
148-
metric_values = fs_mapping_similarity_avg,
147+
metric_ids = list("flowsom_mean_mapping_similarity"),
148+
metric_values = list(fs_mapping_similarity_avg),
149149
fsom_absdiff_by_donor_refsplit = fsom_absdiff_by_donor_refsplit,
150150
fsom_parameters = list(
151151
"xdim" = grid_xdim,

0 commit comments

Comments
 (0)