Point the full run scripts at build/main - #129
Merged
Merged
Conversation
* run_full_hpc.sh was still pinned to build/update_ilisi * run_full_seqeracloud.sh labelled the full run as test_subset
Member
Author
|
Merging this since this is most likely ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Two leftovers in the launch scripts that would bite on the next full run:
scripts/run_benchmark/wehi_hpc/run_full_hpc.shstill passes--revision build/update_ilisi, so a full HPC run would launch the build of a feature branch rather thanbuild/main.scripts/run_benchmark/run_full_seqeracloud.shtags the run with--labels task_cyto_batch_integration,test_subset, which makes full runs show up as test runs on Seqera.Happy to be told the
build/update_ilisipin was deliberate and should stay for now -- just flagging it because it is easy to miss.Found while reviewing the task ahead of the next full benchmark run -- see also the sibling PRs.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!