Repository navigation
Commit ba54e79
committed
tests: fix the PR title check broken by the action bump to v6.1.1
Since v6.1.0 each line of the `types` input is treated as a regex
pattern auto-wrapped in `^ $` (amannn/action-semantic-pull-request#292),
so the trailing "# comment" became part of the pattern: the line
"bugfix # bug fixes" means regex ^bugfix # bug fixes$, which can never
match the type token in a PR title. Every PR has failed the "Lint PR"
check since the bump in ff17f2b.
Under @v4 the input was split on whitespace into plain strings, so
"bugfix # bug fixes" accidentally yielded the bare token "bugfix", which
matched. That accidental tolerance is gone in v6.
Fix: list each type as one bare line, as the v6 docs describe and as
other repos pinning the same v6.1.1 SHA do:
https://github.com/cdklabs/cdk-cicd-wrapper/blob/main/.github/workflows/pull-request-lint.yml#L22-L301 parent 56819eb commit ba54e79
1 file changed
Lines changed: 9 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
0 commit comments