Repository navigation
test: fix flaky test at boringssl environment - #2480
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the t/170-proxy-ssl-cert.t test gating so the entire file is skipped when the test runner’s Nginx is using BoringSSL, aligning this test’s runtime requirements with other SSL-related test constraints in the suite.
Changes:
- Detect BoringSSL via
nginx -Voutput andplan(skip_all ...)for this file. - Preserve existing OpenSSL-version-based skipping and test planning logic for non-BoringSSL builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zhuizhuhaomeng
previously approved these changes
Mar 10, 2026
oowl
commented
Mar 10, 2026
| } | ||
| } | ||
| --- config | ||
| # fixme: getsslsession doesn't work with BoringSSL TLSv1.3 case, temporarily disable TLSv1.3 for this test. |
oowl
changed the title
zhuizhuhaomeng
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.