Skip to content

test: fix flaky test at boringssl environment #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhuizhuhaomeng merged 3 commits into from
Mar 10, 2026
Merged

test: fix flaky test at boringssl environment #2480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5994c0
test: skip t/170-proxy-ssl-cert.t test for BoringSSL
oowl Mar 10, 2026
938c3d9
test: fix t/138-balancer.t case not handle boringssl error log bug
oowl Mar 10, 2026
ec558ed
test: fix t/170-ssl-session-reuse.t getsslsession not return correctl…
oowl Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion t/138-balancer.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,4 +735,4 @@ qr/502 Bad Gateway/
--- no_error_log
[error]
--- error_log eval
qr/SSL_do_handshake.*routines::tlsv1 alert no application protocol:SSL alert number 120\) while SSL handshaking to upstream/
qr/SSL_do_handshake.*(?:no application protocol|NO_APPLICATION_PROTOCOL).*SSL alert number 120\) while SSL handshaking to upstream/
4 changes: 3 additions & 1 deletion t/170-proxy-ssl-cert.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ repeat_each(3);
my $NginxBinary = $ENV{'TEST_NGINX_BINARY'} || 'nginx';
my $openssl_version = eval { `$NginxBinary -V 2>&1` };

if ($openssl_version =~ m/built with OpenSSL (0|1\.0\.(?:0|1[^\d]|2[a-d]).*)/) {
if ($openssl_version =~ m/BoringSSL/) {
Comment thread
oowl marked this conversation as resolved.
Resolved
plan(skip_all => "does not support BoringSSL");
} elsif ($openssl_version =~ m/built with OpenSSL (0|1\.0\.(?:0|1[^\d]|2[a-d]).*)/) {
plan(skip_all => "too old OpenSSL, need >= 1.0.2e, was $1");
} else {
plan tests => repeat_each() * (blocks() * 5 + 17);
Expand Down
2 changes: 2 additions & 0 deletions t/170-ssl-session-reuse.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ close: 1 nil
}
}
--- config
# fixme: getsslsession doesn't work with BoringSSL TLSv1.3 case, temporarily disable TLSv1.3 for this test.

@oowl oowl Mar 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created a issue: #2481

lua_ssl_protocols TLSv1.2;
resolver $TEST_NGINX_RESOLVER ipv6=off;
location /t {
content_by_lua_block {
Expand Down