Repository navigation
Use JavaFileChecker precondition in ExtractExplicitConstructorInvocationArguments - #1337
Merged
Merged
Conversation
…cationArguments`
22 of 72 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExtractExplicitConstructorInvocationArgumentslimited itself to Java by overridingisAcceptableon its visitor. It now states that limit as a precondition, addingnew JavaFileChecker<>()next toUsesJavaVersion<>(25), as openrewrite/rewrite-testing-frameworks#1217 did forTestMethodsShouldBeVoid. Which files the recipe visits doesn't change, and the comment explaining why other JVM languages are skipped stays next to the precondition.Verified with
./gradlew test --tests '*.ExtractExplicitConstructorInvocationArgumentsTest', running the test JVM on Java 25 (the test class is@EnabledForJreRange(min = JAVA_25), so all of it is skipped on older JDKs): all 20 pass.