Repository navigation
Avoid hardcoded patch version in JavaxValidationMigrationToJakartaValidationTest - #1362
Merged
Merged
Conversation
…idationTest hibernate-validator 7.0.7.Final reached Maven Central on 2026-10-25, breaking the hardcoded 7.0.6.Final expectation, as 7.0.6.Final broke the 7.0.5.Final one in #1321. The recipe upgrades to the newest 7.0.x, so assert on any 7.0.x.Final under the new groupId with the test scope kept, matching the surrounding tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hibernate-validator 7.0.7.Final reached Maven Central today (2026-10-25, 15:07 UTC), so
migrateLegacyHibernateValidatorProviderfails onmain: the recipe upgrades to the newest 7.0.x (newVersion: 7.0.x), and the test expected exactly 7.0.6.Final. #1321 bumped the same line from 7.0.5.Final five days ago.The test now asserts the moved dependency with a pattern, as
UpdateSdkManTest(#1183) and the other jakarta tests do: groupIdorg.hibernate.validator, any7.0.x.Final,testscope kept, and noorg.hibernategroupId left behind../gradlew test --tests 'org.openrewrite.java.migrate.jakarta.JavaxValidationMigrationToJakartaValidationTest':main: 5 tests, 1 failed (expected: <version>7.0.6.Final</version> but was: <version>7.0.7.Final</version>)7\.0\.6: fails against 7.0.7.Final, so the assertion still checks the version