Add missing UsesMethod and UsesType preconditions to recipes that visit every source file (#1227)

Author: timtebeek

src/main/java/org/openrewrite/java/testing/assertj/JUnitTryFailToAssertThatThrownBy.java

@@ -17,12 +17,14 @@
 
 import lombok.Getter;
 import org.openrewrite.ExecutionContext;
+import org.openrewrite.Preconditions;
 import org.openrewrite.Recipe;
 import org.openrewrite.TreeVisitor;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.java.JavaTemplate;
 import org.openrewrite.java.JavaVisitor;
 import org.openrewrite.java.MethodMatcher;
+import org.openrewrite.java.search.UsesMethod;
 import org.openrewrite.java.tree.*;
 
 import java.util.ArrayList;
@@ -48,7 +50,7 @@ public class JUnitTryFailToAssertThatThrownBy extends Recipe {
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {
-        return new JavaVisitor<ExecutionContext>() {
+        return Preconditions.check(Preconditions.or(new UsesMethod<>(ASSERTJ_FAIL_MATCHER), new UsesMethod<>(JUPITER_FAIL_MATCHER), new UsesMethod<>(JUNIT4_FAIL_MATCHER), new UsesMethod<>(JUNIT_FAIL_MATCHER)), new JavaVisitor<ExecutionContext>() {
             @Override
             public J visitTry(J.Try tryBlock, ExecutionContext ctx) {
                 J.Try try_ = (J.Try) super.visitTry(tryBlock, ctx);
@@ -187,6 +189,6 @@ private String buildTemplate(List<Statement> lambdaStatements, String exceptionT
 
                 return template.toString();
             }
-        };
+        });
     }
 }

src/main/java/org/openrewrite/java/testing/assertj/SimplifyAssertJAssertion.java

@@ -21,12 +21,14 @@
 import org.jspecify.annotations.Nullable;
 import org.openrewrite.ExecutionContext;
 import org.openrewrite.Option;
+import org.openrewrite.Preconditions;
 import org.openrewrite.Recipe;
 import org.openrewrite.TreeVisitor;
 import org.openrewrite.java.JavaIsoVisitor;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.java.JavaTemplate;
 import org.openrewrite.java.MethodMatcher;
+import org.openrewrite.java.search.UsesMethod;
 import org.openrewrite.java.tree.J;
 import org.openrewrite.java.tree.TypeUtils;
 
@@ -67,7 +69,7 @@ public class SimplifyAssertJAssertion extends Recipe {
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {
         final MethodMatcher assertToReplace = new MethodMatcher("org.assertj.core.api.* " + this.assertToReplace + "(..)");
-        return new JavaIsoVisitor<ExecutionContext>() {
+        return Preconditions.check(new UsesMethod<>(assertToReplace), new JavaIsoVisitor<ExecutionContext>() {
             @Override
             public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
                 J.MethodInvocation mi = super.visitMethodInvocation(method, ctx);
@@ -94,6 +96,6 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, Execu
                         .build()
                         .apply(getCursor(), mi.getCoordinates().replace(), mi.getSelect());
             }
-        };
+        });
     }
 }

src/main/java/org/openrewrite/java/testing/assertj/SimplifyChainedAssertJAssertion.java

@@ -21,12 +21,14 @@
 import org.jspecify.annotations.Nullable;
 import org.openrewrite.ExecutionContext;
 import org.openrewrite.Option;
+import org.openrewrite.Preconditions;
 import org.openrewrite.Recipe;
 import org.openrewrite.TreeVisitor;
 import org.openrewrite.java.JavaIsoVisitor;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.java.JavaTemplate;
 import org.openrewrite.java.MethodMatcher;
+import org.openrewrite.java.search.UsesMethod;
 import org.openrewrite.java.tree.Expression;
 import org.openrewrite.java.tree.J;
 import org.openrewrite.java.tree.JavaType;
@@ -94,7 +96,7 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
                 new MethodMatcher("org.assertj.core.api.* overridingErrorMessage(..)")
         );
 
-        return new JavaIsoVisitor<ExecutionContext>() {
+        return Preconditions.check(Preconditions.and(new UsesMethod<>(chainedAssertMatcher), new UsesMethod<>(assertToReplace)), new JavaIsoVisitor<ExecutionContext>() {
             @Override
             public J.MethodInvocation visitMethodInvocation(J.MethodInvocation methodInvocation, ExecutionContext ctx) {
                 J.MethodInvocation mi = super.visitMethodInvocation(methodInvocation, ctx);
@@ -228,6 +230,6 @@ private String getStringTemplateAndAppendArguments(J.MethodInvocation assertThat
 
                 return "assertThat(#{any()}).%s(#{any()})";
             }
-        };
+        });
     }
 }

src/main/java/org/openrewrite/java/testing/cleanup/AssertEqualsBooleanToAssertBoolean.java

@@ -17,12 +17,14 @@
 
 import lombok.Getter;
 import org.openrewrite.ExecutionContext;
+import org.openrewrite.Preconditions;
 import org.openrewrite.Recipe;
 import org.openrewrite.TreeVisitor;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.java.JavaTemplate;
 import org.openrewrite.java.JavaVisitor;
 import org.openrewrite.java.MethodMatcher;
+import org.openrewrite.java.search.UsesMethod;
 import org.openrewrite.java.tree.Expression;
 import org.openrewrite.java.tree.J;
 import org.openrewrite.java.tree.JavaType;
@@ -39,7 +41,7 @@ public class AssertEqualsBooleanToAssertBoolean extends Recipe {
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {
-        return new JavaVisitor<ExecutionContext>() {
+        return Preconditions.check(new UsesMethod<>(ASSERT_EQUALS), new JavaVisitor<ExecutionContext>() {
 
             @Override
             public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
@@ -90,6 +92,6 @@ private boolean isBooleanLiteral(J.MethodInvocation method) {
 
                 return false;
             }
-        };
+        });
     }
 }

src/main/java/org/openrewrite/java/testing/cleanup/AssertFalseNegationToAssertTrue.java

@@ -17,12 +17,14 @@
 
 import lombok.Getter;
 import org.openrewrite.ExecutionContext;
+import org.openrewrite.Preconditions;
 import org.openrewrite.Recipe;
 import org.openrewrite.TreeVisitor;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.java.JavaTemplate;
 import org.openrewrite.java.JavaVisitor;
 import org.openrewrite.java.MethodMatcher;
+import org.openrewrite.java.search.UsesMethod;
 import org.openrewrite.java.tree.J;
 
 public class AssertFalseNegationToAssertTrue extends Recipe {
@@ -38,7 +40,7 @@ public class AssertFalseNegationToAssertTrue extends Recipe {
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {
-        return new JavaVisitor<ExecutionContext>() {
+        return Preconditions.check(new UsesMethod<>(ASSERT_FALSE), new JavaVisitor<ExecutionContext>() {
 
             @Override
             public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
@@ -89,6 +91,6 @@ private boolean isUnaryOperatorNot(J.MethodInvocation method) {
 
                 return false;
             }
-        };
+        });
     }
 }

src/main/java/org/openrewrite/java/testing/cleanup/AssertNotEqualsBooleanToAssertBoolean.java

@@ -17,12 +17,14 @@
 
 import lombok.Getter;
 import org.openrewrite.ExecutionContext;
+import org.openrewrite.Preconditions;
 import org.openrewrite.Recipe;
 import org.openrewrite.TreeVisitor;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.java.JavaTemplate;
 import org.openrewrite.java.JavaVisitor;
 import org.openrewrite.java.MethodMatcher;
+import org.openrewrite.java.search.UsesMethod;
 import org.openrewrite.java.tree.Expression;
 import org.openrewrite.java.tree.J;
 import org.openrewrite.java.tree.JavaType;
@@ -39,7 +41,7 @@ public class AssertNotEqualsBooleanToAssertBoolean extends Recipe {
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {
-        return new JavaVisitor<ExecutionContext>() {
+        return Preconditions.check(new UsesMethod<>(ASSERT_NOT_EQUALS), new JavaVisitor<ExecutionContext>() {
 
             @Override
             public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
@@ -89,6 +91,6 @@ private boolean isBooleanLiteral(J.MethodInvocation method) {
 
                 return false;
             }
-        };
+        });
     }
 }

src/main/java/org/openrewrite/java/testing/hamcrest/AssertThatBooleanToAssertJ.java

@@ -17,12 +17,14 @@
 
 import lombok.Getter;
 import org.openrewrite.ExecutionContext;
+import org.openrewrite.Preconditions;
 import org.openrewrite.Recipe;
 import org.openrewrite.TreeVisitor;
 import org.openrewrite.java.JavaIsoVisitor;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.java.JavaTemplate;
 import org.openrewrite.java.MethodMatcher;
+import org.openrewrite.java.search.UsesMethod;
 import org.openrewrite.java.tree.Expression;
 import org.openrewrite.java.tree.J;
 
@@ -37,7 +39,7 @@ public class AssertThatBooleanToAssertJ extends Recipe {
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {
-        return new JavaIsoVisitor<ExecutionContext>() {
+        return Preconditions.check(new UsesMethod<>(ASSERT_THAT_MATCHER), new JavaIsoVisitor<ExecutionContext>() {
             @Override
             public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
                 J.MethodInvocation mi = super.visitMethodInvocation(method, ctx);
@@ -54,6 +56,6 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, Execu
                 }
                 return mi;
             }
-        };
+        });
     }
 }

src/main/java/org/openrewrite/java/testing/junit5/AssertTrueInstanceofToAssertInstanceOf.java

@@ -17,13 +17,15 @@
 
 import lombok.Getter;
 import org.openrewrite.ExecutionContext;
+import org.openrewrite.Preconditions;
 import org.openrewrite.Recipe;
 import org.openrewrite.Tree;
 import org.openrewrite.TreeVisitor;
 import org.openrewrite.java.JavaIsoVisitor;
 import org.openrewrite.java.JavaParser;
 import org.openrewrite.java.JavaTemplate;
 import org.openrewrite.java.MethodMatcher;
+import org.openrewrite.java.search.UsesMethod;
 import org.openrewrite.java.tree.Expression;
 import org.openrewrite.java.tree.J;
 import org.openrewrite.java.tree.JLeftPadded;
@@ -47,7 +49,7 @@ public class AssertTrueInstanceofToAssertInstanceOf extends Recipe {
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {
-        return new JavaIsoVisitor<ExecutionContext>() {
+        return Preconditions.check(Preconditions.or(new UsesMethod<>(JUNIT5_ASSERT_TRUE), new UsesMethod<>(JUNIT4_ASSERT_TRUE)), new JavaIsoVisitor<ExecutionContext>() {
 
             @Override
             public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
@@ -125,6 +127,6 @@ private Expression toClassLiteral(TypedTree clazz) {
                 return new J.FieldAccess(Tree.randomId(), Space.EMPTY, Markers.EMPTY,
                     target, JLeftPadded.build(classKeyword), classType);
             }
-        };
+        });
     }
 }

src/main/java/org/openrewrite/java/testing/junit5/CleanupKotlinJUnit5AssertionImports.java

@@ -17,8 +17,10 @@
 
 import lombok.Getter;
 import org.openrewrite.ExecutionContext;
+import org.openrewrite.Preconditions;
 import org.openrewrite.Recipe;
 import org.openrewrite.TreeVisitor;
+import org.openrewrite.java.search.UsesType;
 import org.openrewrite.java.tree.J;
 import org.openrewrite.kotlin.KotlinIsoVisitor;
 import org.openrewrite.kotlin.tree.K;
@@ -50,7 +52,7 @@ public class CleanupKotlinJUnit5AssertionImports extends Recipe {
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {
-        return new KotlinIsoVisitor<ExecutionContext>() {
+        return Preconditions.check(new UsesType<>("org.junit.jupiter.api.Assertions", false), new KotlinIsoVisitor<ExecutionContext>() {
             @Override
             public K.CompilationUnit visitCompilationUnit(K.CompilationUnit cu, ExecutionContext ctx) {
                 // Check if there's a wildcard import for org.junit.jupiter.api.*
@@ -89,6 +91,6 @@ public K.CompilationUnit visitCompilationUnit(K.CompilationUnit cu, ExecutionCon
 
                 return cu.withImports(filteredImports);
             }
-        };
+        });
     }
 }

src/main/java/org/openrewrite/java/testing/junit6/MinimumJreConditions.java

@@ -23,6 +23,7 @@
 import org.openrewrite.*;
 import org.openrewrite.internal.ListUtils;
 import org.openrewrite.java.*;
+import org.openrewrite.java.search.UsesType;
 import org.openrewrite.java.trait.Annotated;
 import org.openrewrite.java.trait.Literal;
 import org.openrewrite.java.tree.Expression;
@@ -70,7 +71,7 @@ public class MinimumJreConditions extends Recipe {
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {
-        return new JavaIsoVisitor<ExecutionContext>() {
+        return Preconditions.check(Preconditions.or(new UsesType<>(ENABLED_ON_JRE, false), new UsesType<>(DISABLED_ON_JRE, false), new UsesType<>(ENABLED_FOR_JRE_RANGE, false), new UsesType<>(DISABLED_FOR_JRE_RANGE, false)), new JavaIsoVisitor<ExecutionContext>() {
 
             @Override
             public J.CompilationUnit visitCompilationUnit(J.CompilationUnit cu, ExecutionContext ctx) {
@@ -287,7 +288,7 @@ private List<String> extractVersionsFromAnnotationArgument(Expression expression
                 }
                 return singletonList(expression.toString());
             }
-        };
+        });
     }
 
     private static Optional<Expression> getDefaultAttribute(Annotated annotated) {