Only turn the WireMockRule field's @Rule into @RegisterExtension in UseWiremockExtension (#1218)

`UseWiremockExtension` queued a file-wide `ChangeType` from `org.junit.Rule` to `RegisterExtension` as soon as it saw a `new WireMockRule(..)`, so every other rule in the class was retyped too. A `@Rule TemporaryFolder tmp` next to the WireMock rule became `@RegisterExtension TemporaryFolder tmp`, which Jupiter rejects at runtime, and `TemporaryFolderToTempDir` and `TestRuleToTestInfo` later in `JUnit4to5Migration` no longer recognised those fields. Now only the `@Rule` on a `WireMockRule` field is replaced.

Author: timtebeek

src/main/java/org/openrewrite/java/testing/junit5/UseWiremockExtension.java

@@ -20,6 +20,7 @@
 import org.openrewrite.Preconditions;
 import org.openrewrite.Recipe;
 import org.openrewrite.TreeVisitor;
+import org.openrewrite.internal.ListUtils;
 import org.openrewrite.java.*;
 import org.openrewrite.java.search.UsesType;
 import org.openrewrite.java.tree.*;
@@ -28,7 +29,9 @@ public class UseWiremockExtension extends Recipe {
 
     private static final String WIREMOCK_RULE = "com.github.tomakehurst.wiremock.junit.WireMockRule";
     private static final String WIREMOCK_EXTENSION = "com.github.tomakehurst.wiremock.junit5.WireMockExtension";
+    private static final String REGISTER_EXTENSION = "org.junit.jupiter.api.extension.RegisterExtension";
     private static final MethodMatcher newWiremockRule = new MethodMatcher(WIREMOCK_RULE + " <constructor>(..)");
+    private static final AnnotationMatcher RULE = new AnnotationMatcher("@org.junit.Rule");
 
     @Getter
     final String displayName = "Use wiremock extension";
@@ -48,6 +51,19 @@ public J preVisit(J tree, ExecutionContext ctx) {
                 return tree;
             }
 
+            @Override
+            public J visitVariableDeclarations(J.VariableDeclarations multiVariable, ExecutionContext ctx) {
+                J.VariableDeclarations vd = (J.VariableDeclarations) super.visitVariableDeclarations(multiVariable, ctx);
+                if (multiVariable.getVariables().stream().noneMatch(v -> TypeUtils.isOfClassType(v.getType(), WIREMOCK_RULE))) {
+                    return vd;
+                }
+                maybeRemoveImport("org.junit.Rule");
+                maybeAddImport(REGISTER_EXTENSION);
+                return vd.withLeadingAnnotations(ListUtils.map(vd.getLeadingAnnotations(), a -> RULE.matches(a) ?
+                        a.withAnnotationType(TypeTree.<J.Identifier>build("RegisterExtension").withType(JavaType.ShallowClass.build(REGISTER_EXTENSION)).withPrefix(a.getAnnotationType().getPrefix())) :
+                        a));
+            }
+
             @Override
             public J visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
                 J.MethodInvocation mi = (J.MethodInvocation) super.visitMethodInvocation(method, ctx);
@@ -65,8 +81,6 @@ public J visitNewClass(J.NewClass newClass, ExecutionContext ctx) {
                 J.NewClass n = (J.NewClass) super.visitNewClass(newClass, ctx);
                 if (newWiremockRule.matches(n)) {
                     maybeAddImport(WIREMOCK_EXTENSION);
-                    doAfterVisit(new ChangeType("org.junit.Rule", "org.junit.jupiter.api.extension.RegisterExtension", true)
-                            .getVisitor());
 
                     Expression arg = n.getArguments().get(0);
 

src/test/java/org/openrewrite/java/testing/junit5/UseWiremockExtensionTest.java

@@ -206,6 +206,41 @@ String secureBaseUrl() {
         );
     }
 
+    @Test
+    void otherRulesKeepTheirAnnotation() {
+        //language=java
+        rewriteRun(
+          java(
+            """
+              import com.github.tomakehurst.wiremock.junit.WireMockRule;
+              import org.junit.Rule;
+              import org.junit.rules.TemporaryFolder;
+
+              class Test {
+                  @Rule
+                  public WireMockRule wm = new WireMockRule(7001);
+                  @Rule
+                  public TemporaryFolder tmp = new TemporaryFolder();
+              }
+              """,
+            """
+              import com.github.tomakehurst.wiremock.core.WireMockConfiguration;
+              import com.github.tomakehurst.wiremock.junit5.WireMockExtension;
+              import org.junit.Rule;
+              import org.junit.jupiter.api.extension.RegisterExtension;
+              import org.junit.rules.TemporaryFolder;
+
+              class Test {
+                  @RegisterExtension
+                  public WireMockExtension wm = WireMockExtension.newInstance().options(WireMockConfiguration.options().port(7001)).build();
+                  @Rule
+                  public TemporaryFolder tmp = new TemporaryFolder();
+              }
+              """
+          )
+        );
+    }
+
     @Nested
     class InJUnit4to5Migration implements RewriteTest {
 
@@ -293,6 +328,42 @@ public void token() {
             );
         }
 
+        @Test
+        void temporaryFolderNextToWireMockRuleBecomesTempDir() {
+            //language=java
+            rewriteRun(
+              java(
+                """
+                  import com.github.tomakehurst.wiremock.junit.WireMockRule;
+                  import org.junit.Rule;
+                  import org.junit.rules.TemporaryFolder;
+
+                  class WireMockTest {
+                      @Rule
+                      public WireMockRule wm = new WireMockRule(7001);
+                      @Rule
+                      public TemporaryFolder tmp = new TemporaryFolder();
+                  }
+                  """,
+                """
+                  import com.github.tomakehurst.wiremock.core.WireMockConfiguration;
+                  import com.github.tomakehurst.wiremock.junit5.WireMockExtension;
+                  import org.junit.jupiter.api.extension.RegisterExtension;
+                  import org.junit.jupiter.api.io.TempDir;
+
+                  import java.io.File;
+
+                  class WireMockTest {
+                      @RegisterExtension
+                      public WireMockExtension wm = WireMockExtension.newInstance().options(WireMockConfiguration.options().port(7001)).build();
+                      @TempDir
+                      public File tmp;
+                  }
+                  """
+              )
+            );
+        }
+
         @Test
         void stoppedRuleBecomesServer() {
             //language=java