Skip to content

Commit c934a8a

Browse files
authored
Fix typos, over-claiming and inconsistent recipe display names and descriptions (#1231)
1 parent 4cbed4c commit c934a8a

49 files changed

Lines changed: 264 additions & 266 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/main/java/org/openrewrite/java/testing/arquillian/ReplaceArquillianInSequenceAnnotation.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public class ReplaceArquillianInSequenceAnnotation extends Recipe {
3535
private static final AnnotationMatcher TEST_METHOD_ORDER_MATCHER = new AnnotationMatcher("@" + TEST_METHOD_ORDER);
3636

3737
@Getter
38-
final String displayName = "Arquillian JUnit 4 `@InSequence` to JUnit Jupiter `@Order`";
38+
final String displayName = "Replace Arquillian JUnit 4 `@InSequence` with JUnit Jupiter `@Order`";
3939

4040
@Getter
4141
final String description = "Transforms the Arquillian JUnit 4 `@InSequence` to the JUnit Jupiter `@Order`.";

‎src/main/java/org/openrewrite/java/testing/assertj/AssertJBigIntegerRules.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
import static org.assertj.core.data.Percentage.withPercentage;
2828

2929
@RecipeDescriptor(
30-
name = "Adopt AssertJ BigInteger Assertions",
31-
description = "Adopt AssertJ BigInteger Assertions. Favor semantically explicit methods (e.g. " +
30+
name = "Adopt AssertJ `BigInteger` assertions",
31+
description = "Adopt AssertJ `BigInteger` assertions. Favor semantically explicit methods (e.g. " +
3232
"`myBigInteger.isZero()` over `myBigInteger.isEqualTo(0)`)."
3333
)
3434
public class AssertJBigIntegerRules {

‎src/main/java/org/openrewrite/java/testing/assertj/AssertJByteRules.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
import static org.assertj.core.data.Percentage.withPercentage;
2626

2727
@RecipeDescriptor(
28-
name = "Adopt AssertJ Byte Assertions",
29-
description = "Adopt AssertJ Byte Assertions. Favor semantically explicit methods (e.g. " +
28+
name = "Adopt AssertJ `Byte` assertions",
29+
description = "Adopt AssertJ `Byte` assertions. Favor semantically explicit methods (e.g. " +
3030
"`myByte.isZero()` over `myByte.isEqualTo(0)`)."
3131
)
3232
public class AssertJByteRules {

‎src/main/java/org/openrewrite/java/testing/assertj/AssertJDoubleRules.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
import static org.assertj.core.data.Percentage.withPercentage;
2727

2828
@RecipeDescriptor(
29-
name = "Adopt AssertJ Double Assertions",
30-
description = "Adopt AssertJ Double Assertions. Favor semantically explicit methods (e.g. " +
29+
name = "Adopt AssertJ `Double` assertions",
30+
description = "Adopt AssertJ `Double` assertions. Favor semantically explicit methods (e.g. " +
3131
"`myDouble.isZero()` over `myDouble.isEqualTo(0.0)`)."
3232
)
3333
public class AssertJDoubleRules {

‎src/main/java/org/openrewrite/java/testing/assertj/AssertJFloatRules.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
import static org.assertj.core.data.Percentage.withPercentage;
2727

2828
@RecipeDescriptor(
29-
name = "Adopt AssertJ Float Assertions",
30-
description = "Adopt AssertJ Float Assertions. Favor semantically explicit methods (e.g. " +
29+
name = "Adopt AssertJ `Float` assertions",
30+
description = "Adopt AssertJ `Float` assertions. Favor semantically explicit methods (e.g. " +
3131
"`myFloat.isZero()` over `myFloat.isEqualTo(0.0f)`)."
3232
)
3333
public class AssertJFloatRules {

‎src/main/java/org/openrewrite/java/testing/assertj/AssertJIntegerRules.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
import static org.assertj.core.data.Percentage.withPercentage;
2626

2727
@RecipeDescriptor(
28-
name = "Adopt AssertJ Integer Assertions",
29-
description = "Adopt AssertJ Integer Assertions. Favor semantically explicit methods (e.g. " +
28+
name = "Adopt AssertJ `Integer` assertions",
29+
description = "Adopt AssertJ `Integer` assertions. Favor semantically explicit methods (e.g. " +
3030
"`myInteger.isZero()` over `myInteger.isEqualTo(0)`)."
3131
)
3232
public class AssertJIntegerRules {

‎src/main/java/org/openrewrite/java/testing/assertj/AssertJLongRules.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
import static org.assertj.core.data.Percentage.withPercentage;
2626

2727
@RecipeDescriptor(
28-
name = "Adopt AssertJ Long Assertions",
29-
description = "Adopt AssertJ Long Assertions. Favor semantically explicit methods (e.g. " +
28+
name = "Adopt AssertJ `Long` assertions",
29+
description = "Adopt AssertJ `Long` assertions. Favor semantically explicit methods (e.g. " +
3030
"`myLong.isZero()` over `myLong.isEqualTo(0)`)."
3131
)
3232
public class AssertJLongRules {

‎src/main/java/org/openrewrite/java/testing/assertj/AssertJShortRules.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@
2525
import static org.assertj.core.data.Percentage.withPercentage;
2626

2727
@RecipeDescriptor(
28-
name = "Adopt AssertJ Short Assertions",
29-
description = "Adopt AssertJ Short Assertions. Favor semantically explicit methods (e.g. " +
28+
name = "Adopt AssertJ `Short` assertions",
29+
description = "Adopt AssertJ `Short` assertions. Favor semantically explicit methods (e.g. " +
3030
"`myShort.isZero()` over `myShort.isEqualTo(0)`)."
3131
)
3232
public class AssertJShortRules {

‎src/main/java/org/openrewrite/java/testing/assertj/IsEqualToIgnoringMillisToIsCloseTo.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import static org.assertj.core.api.Assertions.assertThat;
2525

2626
@RecipeDescriptor(
27-
name = "Replace `AbstractDateAssert#isEqualToIgnoringMillis(java.util.Date)` by `by isCloseTo(Date, long)`",
27+
name = "Replace `AbstractDateAssert#isEqualToIgnoringMillis(java.util.Date)` with `isCloseTo(Date, long)`",
2828
description = "`isEqualToIgnoringMillis()` is deprecated in favor of `isCloseTo()`."
2929
)
3030
@SuppressWarnings({"java:S1874", "deprecation"})

‎src/main/java/org/openrewrite/java/testing/assertj/JUnitAssertArrayEqualsToAssertThat.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ public class JUnitAssertArrayEqualsToAssertThat extends Recipe {
4141
private static final MethodMatcher ASSERT_ARRAY_EQUALS_MATCHER = new MethodMatcher(JUNIT + " assertArrayEquals(..)", true);
4242

4343
@Getter
44-
final String displayName = "JUnit `assertArrayEquals` to assertJ";
44+
final String displayName = "JUnit `assertArrayEquals` to AssertJ";
4545

4646
@Getter
47-
final String description = "Convert JUnit-style `assertArrayEquals()` to AssertJ's `assertThat().contains()` equivalents.";
47+
final String description = "Convert JUnit-style `assertArrayEquals()` to AssertJ's `assertThat().containsExactly()` equivalents.";
4848

4949
@Override
5050
public TreeVisitor<?, ExecutionContext> getVisitor() {

0 commit comments

Comments
 (0)