Only replace assertNotEquals(false, <boolean>) when the second argument is a primitive boolean (#1220)

`AssertNotEqualsBooleanToAssertBoolean` rewrote `assertNotEquals(false, x)` to `assertTrue(x)` for any `x`. With a `Map<String, Object>`, `assertNotEquals(false, map.get("k"))` became `assertTrue(map.get("k"))`, which does not compile, and with a `Boolean` holding `null` a passing assertion became an unboxing `NullPointerException`. Require a primitive `boolean`, as `AssertEqualsBooleanToAssertBoolean` already does.

Author: timtebeek

src/main/java/org/openrewrite/java/testing/cleanup/AssertNotEqualsBooleanToAssertBoolean.java

@@ -44,7 +44,7 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
             @Override
             public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
                 J.MethodInvocation mi = (J.MethodInvocation) super.visitMethodInvocation(method, ctx);
-                if (ASSERT_NOT_EQUALS.matches(mi) && isBooleanLiteral(mi)) {
+                if (ASSERT_NOT_EQUALS.matches(mi) && isBooleanLiteral(mi) && JavaType.Primitive.Boolean == mi.getArguments().get(1).getType()) {
                     StringBuilder sb = new StringBuilder();
                     String assertMethod = Boolean.parseBoolean(((J.Literal) mi.getArguments().get(0)).getValueSource()) ?
                             "assertFalse" : "assertTrue";

src/test/java/org/openrewrite/java/testing/cleanup/AssertNotEqualsBooleanToAssertBooleanTest.java

@@ -105,4 +105,42 @@ void test() {
           )
         );
     }
+
+    @Test
+    void noChangeForObjectArgument() {
+        //language=java
+        rewriteRun(
+          java(
+            """
+              import java.util.Map;
+
+              import static org.junit.jupiter.api.Assertions.assertNotEquals;
+
+              class Test {
+                  void test(Map<String, Object> map) {
+                      assertNotEquals(false, map.get("k"));
+                  }
+              }
+              """
+          )
+        );
+    }
+
+    @Test
+    void noChangeForBoxedBooleanArgument() {
+        //language=java
+        rewriteRun(
+          java(
+            """
+              import static org.junit.jupiter.api.Assertions.assertNotEquals;
+
+              class Test {
+                  void test(Boolean b) {
+                      assertNotEquals(false, b);
+                  }
+              }
+              """
+          )
+        );
+    }
 }