Repository navigation
Use JavaFileChecker preconditions instead of isAcceptable overrides - #1219
Merged
Merged
Conversation
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 6f44114 in #1217, which made the same change in
TestMethodsShouldBeVoid. Five more recipes limited themselves to Java (or Java and Kotlin) by overridingisAcceptableon their visitor. They now state that limit as a precondition instead, withnew JavaFileChecker<>()(orPreconditions.or(new JavaFileChecker<>(), new KotlinFileChecker<>())inAssertThrowsOnLastStatement) added to the existing precondition. Which files each recipe visits doesn't change, and the comments explaining why other languages are skipped stay next to the precondition.Verified with
./gradlew teston the tests of the five changed recipes: all 65 pass.