Repository navigation
Only convert Java sources in UseAssertSame - #1223
Merged
Merged
Conversation
In Kotlin (and Groovy) `==` calls `equals`, so turning `assertTrue(listOf(1) == listOf(1))` into `assertSame(listOf(1), listOf(1))` changed a passing equality check into a failing identity check. Kotlin tests reach this recipe through `JupiterBestPractices`, so restrict it to Java compilation units with a `JavaFileChecker` precondition.
10 of 76 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Kotlin (and Groovy)
==callsequals; identity is===.UseAssertSamestill treated==as identity there, soJupiterBestPracticesturned a passing equality check into a failing identity check:The recipe now only visits Java compilation units, using the same
JavaFileCheckerprecondition as #1219. I did not map Kotlin===toassertSame; that would need a separateK.Binarypath, and leaving Kotlin alone is the safe default.Verified with
./gradlew test --tests 'org.openrewrite.java.testing.junit5.*' --tests 'org.openrewrite.java.testing.cleanup.AssertTrueComparisonToAssertEqualsTest': 479 tests, 0 failures (4 skipped). The newkotlinEqualityIsNotIdentitytest fails without the fix.Fixes item C12 of #1211.