Repository navigation
Only remove a direct PowerMockTestCase or PowerMockConfiguration superclass in RemovePowerMockClassExtensions - #1224
Merged
Conversation
…superclass in `RemovePowerMockClassExtensions` The recipe checked the `extends` clause with `TypeUtils.isAssignableTo`, so a test such as `class FooTest extends MyBaseTest`, where the user's own `MyBaseTest` extends `PowerMockTestCase`, also lost its superclass and with it every inherited helper, leaving code that no longer compiles. Matching the exact type with `TypeUtils.isOfClassType` unwraps only the base class that extends PowerMock directly and keeps subclasses of it intact.
23 of 76 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemovePowerMockClassExtensionsmatched theextendsclause withTypeUtils.isAssignableTo, so it also stripped the superclass from subclasses of a user's own PowerMock base class. Withabstract class MyBaseTest extends PowerMockTestCase, the recipe correctly turned that intoabstract class MyBaseTest, but it also turnedclass FooTest extends MyBaseTestintoclass FooTest, soFooTestlost every inherited helper and no longer compiled.The recipe now uses
TypeUtils.isOfClassType, so it only removes anextendsclause whose type is exactlyPowerMockTestCaseorPowerMockConfiguration. The base class is still unwrapped and its subclasses keepextends MyBaseTest. A new regression test,subclassOfOwnBaseClassKeepsExtension, fails onmainand passes with this change.Verified with
./gradlew test --tests 'org.openrewrite.java.testing.mockito.*': 466 tests, 0 failures, 2 skipped. That run includesRemovePowerMockClassExtensionsTest(3) and theReplacePowerMockitoIntegrationTestcomposite (58).Fixes item F1 of #1211.