Fix monitor deep-link datasource menu initialization - #1413
Open
jackiehanyang wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jackie <jkhanjob@gmail.com>
jackiehanyang
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
getsaurabh02,
lezzago,
praveensameneni,
rishabhmaurya,
riysaxen-amzn and
sbcd90
as code owners
April 10, 2026 20:09
Member
|
LGTM, but please add some unit tests for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Alerting monitor deep-link initialization in datasource-enabled environments.
Related Issue
opensearch-project/OpenSearch-Dashboards#11439
What changed
Main.jsto always passactiveOptionas an array to the datasource menu[]while datasource state is still loading[{ id }]when a datasource is selectedWhy
The monitor details deep link from Metrics can enter Alerting before datasource state is fully resolved. In that case,
activeOptioncould beundefined, which is not the shape expected by the datasource menu and could break page initialization.This keeps the Alerting-side fix minimal and localized to the deep-link boot path.
Testing
View monitorlink opens correctly from Metrics