chore: resolutions and dependencies cleanup, address CVEs - #1494
chore: resolutions and dependencies cleanup, address CVEs#1494tomkdgun wants to merge 4 commits into
Conversation
9941101 to
31a0e0e
Compare
Signed-off-by: Tomasz Kania <tomasz.kania@pl.ibm.com>
Signed-off-by: Tomasz Kania <tomasz.kania@pl.ibm.com>
Signed-off-by: Tomasz Kania <tomasz.kania@pl.ibm.com>
Signed-off-by: Tomasz Kania <tomasz.kania@pl.ibm.com>
|
Risk: removing This PR drops ~25 The committed The concern is durability: with the overrides gone, there is no longer a guard preventing a vulnerable version from coming back. A future Suggestion: either keep the security-motivated |
|
@lezzago My understanding is that yarn.lock + yarn audit should be used in typical cases to address CVEs. Also in many cases CVE should be fixed on OpenSearch Dashboard side, not on plugin. |
Description
There are many leftover resolutions/overrides from past fixes that are no longer relevant and necessary after recent changes.
We need to attempt to remove as many manual resolutions as possible to clean up our dependencies.
Some of them are bringing in modules that are no longer in the dependency tree, override newer versions by older or are not aligned with OpenSearch Dashboard 3.8.0 dependencies.
In some cases resolutions were used instead of dependencies/devDependencies, or completely assume that some specific dependencies will be provided by OpenSearch Dashboard.
Changes:
yarn auditand address these possible to fixTesting:
yarn osd bootstrapwith OpenSearch Dashboard 3.8yarn buildyarn test:jestDetails:
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.