fix: Update ProcessorGenerationContext test calls for new param - #1909
Merged
heemin32 merged 1 commit intoJul 24, 2026
Conversation
Signed-off-by: Rex Zhang <yichenzg@amazon.com>
RexyZhang2001
requested review from
VijayanB,
bzhangam,
chishui,
heemin32,
jmazanec15,
junqiu-lei,
martin-gaievski,
minalsha,
model-collapse,
naveentatikonda,
navneet1v,
owaiskazi19,
sean-zheng-amazon,
vamshin,
vibrantvarun,
yuye-aws,
zane-neo and
zhichao-aws
as code owners
July 24, 2026 22:12
heemin32
approved these changes
Jul 24, 2026
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1909 +/- ##
============================================
- Coverage 83.45% 83.44% -0.01%
- Complexity 3898 3899 +1
============================================
Files 291 291
Lines 13844 13844
Branches 2304 2304
============================================
- Hits 11553 11552 -1
- Misses 1456 1458 +2
+ Partials 835 834 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
heemin32
pushed a commit
that referenced
this pull request
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OpenSearch core added a
parentActionparameter to theProcessorGenerationContextrecord (opensearch-project/OpenSearch#22195), changing its constructor from(SearchRequest)to(SearchRequest, String). This brokecompileTestJavaforSemanticHighlightingFactoryTests, causing the neural-search integration test suite to fail to build.This PR updates all 11
ProcessorGenerationContextconstructor calls in the test file to pass the new parameter asnull, since these tests don't exercise parent-action-specific behavior. No production code changes were needed sinceSemanticHighlightingFactoryonly readscontext.searchRequest().Related Issues
Resolves #1904
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.