Skip to content

fix: Update ProcessorGenerationContext test calls for new param - #1909

Merged
heemin32 merged 1 commit into
opensearch-project:mainfrom
RexyZhang2001:fix/processor-generation-context-test-params
Jul 24, 2026
Merged

fix: Update ProcessorGenerationContext test calls for new param#1909
heemin32 merged 1 commit into
opensearch-project:mainfrom
RexyZhang2001:fix/processor-generation-context-test-params

Conversation

@RexyZhang2001

Copy link
Copy Markdown
Contributor

Description

OpenSearch core added a parentAction parameter to the ProcessorGenerationContext record (opensearch-project/OpenSearch#22195), changing its constructor from (SearchRequest) to (SearchRequest, String). This broke compileTestJava for SemanticHighlightingFactoryTests, causing the neural-search integration test suite to fail to build.

This PR updates all 11 ProcessorGenerationContext constructor calls in the test file to pass the new parameter as null, since these tests don't exercise parent-action-specific behavior. No production code changes were needed since SemanticHighlightingFactory only reads context.searchRequest().

Related Issues

Resolves #1904

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rex Zhang <yichenzg@amazon.com>
@heemin32 heemin32 added backport 3.8 and removed autocut Created by automated workflow v3.8.0 labels Jul 24, 2026
@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.44%. Comparing base (094d089) to head (b642a7f).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1909      +/-   ##
============================================
- Coverage     83.45%   83.44%   -0.01%     
- Complexity     3898     3899       +1     
============================================
  Files           291      291              
  Lines         13844    13844              
  Branches       2304     2304              
============================================
- Hits          11553    11552       -1     
- Misses         1456     1458       +2     
+ Partials        835      834       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@heemin32
heemin32 merged commit d35bab4 into opensearch-project:main Jul 24, 2026
94 of 116 checks passed
heemin32 pushed a commit that referenced this pull request Jul 24, 2026
… (#1910)

(cherry picked from commit d35bab4)

Signed-off-by: Rex Zhang <yichenzg@amazon.com>
Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: Rex Zhang <yichenzg@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Integration Test Failed for neural-search-3.8.0

2 participants