Skip to content

Add mavenLocal to pluginManagement repositories (neural-search) - #1923

Closed
peterzhuamazon wants to merge 1 commit into
opensearch-project:mainfrom
peterzhuamazon:fix-maven-429
Closed

Add mavenLocal to pluginManagement repositories (neural-search)#1923
peterzhuamazon wants to merge 1 commit into
opensearch-project:mainfrom
peterzhuamazon:fix-maven-429

Conversation

@peterzhuamazon

Copy link
Copy Markdown
Member

Description

Add mavenLocal to pluginManagement repositories (neural-search)

Issues Resolved

opensearch-project/opensearch-build#6278 (comment)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit acc4abf.

Hard block: Issues at High severity or above will block this PR from merging.

PathLineSeverityDescription
settings.gradle13highmavenLocal() added as the first repository in pluginManagement.repositories, giving it highest resolution priority over all other sources. This is a dependency confusion attack vector: any artifact placed in the local Maven cache (~/.m2/repository) will shadow legitimate remote plugins. In CI/CD environments this could allow an attacker with write access to the build agent's local cache to substitute malicious Gradle plugins before the build resolves them from the trusted remote repositories. mavenLocal() is rarely needed in pluginManagement and its position at the top of the list is highly suspicious.

The table above displays the top 10 most important findings.

Total: 1 | Critical: 0 | High: 1 | Medium: 0 | Low: 0


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@github-project-automation github-project-automation Bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Aug 1, 2026
@codecov

codecov Bot commented Aug 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.42%. Comparing base (5facc2e) to head (acc4abf).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1923      +/-   ##
============================================
- Coverage     83.45%   83.42%   -0.03%     
+ Complexity     3884     3882       -2     
============================================
  Files           291      291              
  Lines         13819    13819              
  Branches       2294     2294              
============================================
- Hits          11532    11528       -4     
- Misses         1454     1457       +3     
- Partials        833      834       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant