HYPERFLEET-1405 - fix: regenerate stale manager RBAC, restore lint rules, fill in README

manager-role still granted get;list;watch on core pods, a leftover from
before HyperFleetConfig existed. It never picked up the hyperfleetconfigs
CRUD/status/finalizers permissions the controller's kubebuilder:rbac
markers declare, so the deployed operator had no access to its own CR.
Regenerated via `make manifests`.

Also restores the depguard (sort->slices) and modernize lint rules
dropped in the operator-sdk re-scaffold, and replaces the placeholder
README overview/description with real content.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: ciaranRoche

.golangci.yml

@@ -5,6 +5,7 @@ linters:
   default: none
   enable:
     - copyloopvar
+    - depguard
     - dupl
     - errcheck
     - ginkgolinter
@@ -13,6 +14,7 @@ linters:
     - govet
     - ineffassign
     - lll
+    - modernize
     - misspell
     - nakedret
     - prealloc
@@ -22,10 +24,20 @@ linters:
     - unparam
     - unused
   settings:
+    depguard:
+      rules:
+        forbid-sort-pkg:
+          deny:
+            - pkg: sort
+              desc: Should be replaced with slices package
     revive:
       rules:
         - name: comment-spacings
         - name: import-shadowing
+    modernize:
+      disable:
+        - omitzero
+        - newexpr
   exclusions:
     generated: lax
     rules:

README.md

@@ -1,8 +1,10 @@
 # hyperfleet-operator
-// TODO(user): Add simple overview of use/purpose
+
+A Kubernetes operator for HyperFleet cluster lifecycle management.
 
 ## Description
-// TODO(user): An in-depth paragraph about your project and overview of use
+
+hyperfleet-operator packages and delivers HyperFleet as a standard Kubernetes operator, installed and managed through OLM. It exposes a single cluster-scoped custom resource, `HyperFleetConfig`, as the entire partner-facing surface: install, configure, and observe HyperFleet through that one CR and its status conditions, with everything else the operator manages kept internal.
 
 ## Getting Started
 

config/rbac/role.yaml

@@ -1,11 +1,32 @@
+---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
-  labels:
-    app.kubernetes.io/name: hyperfleet-operator
-    app.kubernetes.io/managed-by: kustomize
   name: manager-role
 rules:
-- apiGroups: [""]
-  resources: ["pods"]
-  verbs: ["get", "list", "watch"]
+- apiGroups:
+  - hyperfleet.redhat.com
+  resources:
+  - hyperfleetconfigs
+  verbs:
+  - create
+  - delete
+  - get
+  - list
+  - patch
+  - update
+  - watch
+- apiGroups:
+  - hyperfleet.redhat.com
+  resources:
+  - hyperfleetconfigs/finalizers
+  verbs:
+  - update
+- apiGroups:
+  - hyperfleet.redhat.com
+  resources:
+  - hyperfleetconfigs/status
+  verbs:
+  - get
+  - patch
+  - update

test/utils/utils.go

@@ -181,8 +181,7 @@ func LoadImageToKindClusterWithName(name string) error {
 // according to line breakers, and ignores the empty elements in it.
 func GetNonEmptyLines(output string) []string {
 	var res []string
-	elements := strings.Split(output, "\n")
-	for _, element := range elements {
+	for element := range strings.SplitSeq(output, "\n") {
 		if element != "" {
 			res = append(res, element)
 		}