HYPERFLEET-1406 - feat: Define the HyperFleetConfig CRD (v1alpha1)

.gitignore

@@ -5,6 +5,7 @@
 *.so
 *.dylib
 bin/*
+_output/
 Dockerfile.cross
 
 # Test binary, built with `go test -c`

Makefile

@@ -123,6 +123,15 @@ vet: ## Run go vet against code.
 ENVTEST_K8S_VERSION ?= $(shell go list -m -f "{{ .Version }}" k8s.io/api | awk -F'[v.]' '{printf "1.%d", $$3}')
 KIND_CLUSTER ?= hyperfleet-operator-test-e2e
 
+# On Linux, setup-envtest stores its downloaded control-plane binaries under
+# $XDG_DATA_HOME, falling back to $HOME/.local/share (store/helpers.go). OpenShift
+# CI's unit step runs with HOME=/ (unwritable) and no XDG_DATA_HOME set, so the
+# store resolves to /.local/share and setup-envtest dies with "mkdir /.local:
+# permission denied" — leaving KUBEBUILDER_ASSETS empty and the suite unable to
+# find etcd. Point XDG_DATA_HOME at a writable path inside the repo so the store
+# is always creatable. `?=` lets a developer or CI override it.
+export XDG_DATA_HOME ?= $(ROOT_DIR)_output/.local/share
+
 
 # TODO(user): To use a different vendor for e2e tests, modify the setup under 'tests/e2e'.
 # The default setup assumes Kind is pre-installed and builds/loads the Manager Docker image locally.
@@ -131,7 +140,29 @@ KIND_CLUSTER ?= hyperfleet-operator-test-e2e
 
 .PHONY: test
 test: manifests generate fmt vet ## Run tests.
-	KUBEBUILDER_ASSETS="$(shell $(SETUP_ENVTEST) use $(ENVTEST_K8S_VERSION) -p path)" go test $$(go list ./... | grep -v /e2e) -coverprofile cover.out
+	# Resolve the envtest control-plane binaries. We deliberately do NOT honor the
+	# ambient KUBEBUILDER_ASSETS here: it is the standard variable envtest tooling
+	# exports, so a stale value in a developer's shell (or leftover from another
+	# repo/branch) would silently bypass the ENVTEST_K8S_VERSION pin and run the
+	# suite against the wrong control-plane version. Instead, an explicit
+	# CI_KUBEBUILDER_ASSETS opt-in lets an environment that pre-bakes the binaries
+	# supply its own path without that footgun; otherwise we fall back to
+	# setup-envtest at the pinned version. (Neither our GitHub Actions nor the
+	# OpenShift CI unit step pre-bakes today, so in practice the fallback is what
+	# executes everywhere.)
+	#
+	# Resolve that fallback in the recipe shell (via $$(...)) rather than make's
+	# $(shell ...): $(shell ...) runs at parse time on every make invocation (even
+	# unrelated targets) and cannot see a value exported into the recipe environment.
+	#
+	# Assign on its own line so that, under .SHELLFLAGS -e, a setup-envtest failure
+	# aborts here with its real error instead of being masked by go test's exit
+	# status (a bare `VAR="$$(cmd)" go test` reports go test's status, not cmd's).
+	# Then require a non-empty path so a silent empty resolve can't launch the
+	# suite with no control-plane binaries ("etcd: executable file not found").
+	assets="$${CI_KUBEBUILDER_ASSETS:-$$($(SETUP_ENVTEST) use $(ENVTEST_K8S_VERSION) -p path)}"; \
+	[ -n "$$assets" ] || { echo "error: envtest assets path is empty; setup-envtest did not resolve envtest binaries (set CI_KUBEBUILDER_ASSETS to override)" >&2; exit 1; }; \
+	KUBEBUILDER_ASSETS="$$assets" go test $$(go list ./... | grep -v /e2e) -coverprofile cover.out
 
 .PHONY: setup-test-e2e
 setup-test-e2e: ## Set up a Kind cluster for e2e tests if it does not exist

PROJECT

@@ -13,11 +13,11 @@ repo: github.com/openshift-hyperfleet/hyperfleet-operator
 resources:
 - api:
     crdVersion: v1
-    namespaced: true
+    namespaced: false
   controller: true
   domain: redhat.com
   group: hyperfleet
   kind: HyperFleetConfig
-  path: github.com/openshift-hyperfleet/hyperfleet-operator/api/v1alpha
-  version: v1alpha
+  path: github.com/openshift-hyperfleet/hyperfleet-operator/api/v1alpha1
+  version: v1alpha1
 version: "3"

api/v1alpha/groupversion_info.go → api/v1alpha1/groupversion_info.go

@@ -14,10 +14,10 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-// Package v1alpha contains API Schema definitions for the hyperfleet v1alpha API group.
+// Package v1alpha1 contains API Schema definitions for the hyperfleet v1alpha1 API group.
 // +kubebuilder:object:generate=true
 // +groupName=hyperfleet.redhat.com
-package v1alpha
+package v1alpha1
 
 import (
 	"k8s.io/apimachinery/pkg/runtime/schema"
@@ -26,7 +26,7 @@ import (
 
 var (
 	// GroupVersion is group version used to register these objects.
-	GroupVersion = schema.GroupVersion{Group: "hyperfleet.redhat.com", Version: "v1alpha"}
+	GroupVersion = schema.GroupVersion{Group: "hyperfleet.redhat.com", Version: "v1alpha1"}
 
 	// SchemeBuilder is used to add go types to the GroupVersionKind scheme.
 	SchemeBuilder = &scheme.Builder{GroupVersion: GroupVersion}