Skip to content

Set netapp_transport_type=http on cinder NetApp backends - #847

Open
fmount wants to merge 1 commit into
openstack-k8s-operators:mainfrom
fmount:netapp-fix
Open

Set netapp_transport_type=http on cinder NetApp backends#847
fmount wants to merge 1 commit into
openstack-k8s-operators:mainfrom
fmount:netapp-fix

Conversation

@fmount

@fmount fmount commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

The NetApp ONTAP drivers now default to HTTPS, so backends pinning netapp_server_port=80 must declare the transport explicitly.
Also fix a uni02beta volume_driver typo (netapp.c1ommon -> netapp.common).

Reference: https://opendev.org/openstack/cinder/src/branch/stable/2026.2/releasenotes/notes/netapp-https-default-2157914.yaml

@fmount
Set netapp_transport_type=http on cinder NetApp backends
666bdf7 
The NetApp ONTAP drivers now default to HTTPS, so backends pinning
netapp_server_port=80 must declare the transport explicitly or move to
443. Confirmed in CI as a job-level override on uni07eta and uni02beta;
uni05epsilon and dz-storage carry the same port-80 config.
Also fix a uni02beta volume_driver typo (netapp.c1ommon -> netapp.common).

Reference: https://opendev.org/openstack/cinder/src/branch/stable/2026.2/releasenotes/notes/netapp-https-default-2157914.yaml

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@fmount
fmount requested a review from a team as a code owner October 26, 2026 11:06
@openshift-ci
openshift-ci Bot requested review from abays and fultonj October 26, 2026 11:06
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e8a70f43-093c-4dd4-a044-73d019df61e1
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@fmount
fmount marked this pull request as draft October 26, 2026 11:19
@fmount
fmount marked this pull request as ready for review October 26, 2026 11:23
karelyatin
karelyatin approved these changes Oct 26, 2026
View reviewed changes

@karelyatin karelyatin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Oct 26, 2026
abays
abays reviewed Oct 26, 2026
View reviewed changes

@abays abays left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Assuming we're good with testing, we'll need @openstack-k8s-operators/ciops for final approval

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Build succeeded (check pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/678ec0e1b6a849b0b62a9e95f9b79f4d

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-dz-storage SUCCESS in 6m 26s
✔️ rhoso-architecture-validate-uni02beta SUCCESS in 5m 00s
✔️ rhoso-architecture-validate-uni05epsilon SUCCESS in 7m 36s
✔️ rhoso-architecture-validate-uni07eta SUCCESS in 6m 32s

@fultonj

fultonj commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Francesco confirmed this is safe to merge

arxcruz
arxcruz approved these changes Oct 27, 2026
View reviewed changes

@arxcruz arxcruz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

fultonj
fultonj approved these changes Oct 27, 2026
View reviewed changes

@fultonj fultonj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci

openshift-ci Bot commented Oct 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arxcruz, fmount, fultonj, karelyatin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abays abays abays left review comments
@arxcruz arxcruz arxcruz approved these changes
@fultonj fultonj fultonj approved these changes
@karelyatin karelyatin karelyatin approved these changes

Assignees

@arxcruz arxcruz

@fultonj fultonj

@abays abays

@karelyatin karelyatin

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fmount @fultonj @arxcruz @abays @karelyatin