Repository navigation
Commit fdd1199
Remove unnecessary pods RBAC permissions
OpenStackClient's workload rbacRules granted full CRUD on core Pods to the
ServiceAccount mounted into the OpenStackClient pod itself. That pod's
entrypoint is a bare `sleep infinity` - any capability comes from what an
admin runs interactively via exec, not from Kubernetes API access, so this
grant is unnecessary and is removed entirely. The operator's own
kubebuilder marker for pods on this same controller is untouched: it's
independently justified by OpenStackClientReconciler directly
creating/patching/deleting and watching (Owns(&corev1.Pod{})) that pod.
Also narrow two dataplane controllers to their real usage:
- OpenStackDataPlaneNodeSetReconciler only lists Pods (raw clientset,
diagnostic listing of failed-deployment pods). Narrow its marker from
full CRUD to list.
- OpenStackDataPlaneDeploymentReconciler had no pods marker of its own at
all, despite GetAnsibleExecutionSummary listing Pods via the cached
client (needs list;watch for the informer) to build the ansible
execution summary. It only worked by relying on the nodeset
controller's now-narrowed marker via the ClusterRole merge - add its own
list;watch marker so a future change to the nodeset controller can't
silently break it.
config/rbac/role.yaml is unchanged: OpenStackClient's own marker already
grants full CRUD on pods for a real, direct need, so the merged ClusterRole
doesn't shrink. The change is scoped to what gets delegated to workload
ServiceAccounts and to per-controller marker correctness.
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>1 parent b200b5e commit fdd1199
3 files changed
Lines changed: 3 additions & 7 deletions
File tree
- internal/controller
- client
- dataplane
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| |||
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | 169 | | |
175 | 170 | | |
176 | 171 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| 67 | + | |
67 | 68 | | |
68 | 69 | | |
69 | 70 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| |||
0 commit comments