Refactor cliff.Command.run()

* All commands now perform their action in take_action().  Those producing
  output are derived from DisplayCommandBase.

Change-Id: Ic93ba9a2ad449d84242b6aa8624b41379c4fb79a

Author: Dean Troyer

openstackclient/compute/v2/server.py

@@ -22,10 +22,10 @@
 import logging
 import os
 
+from cliff import command
 from cliff import lister
 from cliff import show
 
-from openstackclient.common import command
 from openstackclient.common import utils
 
 
@@ -44,7 +44,7 @@ def _format_servers_list_networks(server):
     return '; '.join(output)
 
 
-class ListServer(command.OpenStackCommand, lister.Lister):
+class ListServer(lister.Lister):
     """List server command"""
 
     api = 'compute'
@@ -98,8 +98,8 @@ def get_parser(self, prog_name):
             )
         return parser
 
-    def get_data(self, parsed_args):
-        self.log.debug('get_data(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         nova_client = self.app.client_manager.compute
         search_opts = {
             'all_tenants': parsed_args.all_tenants,
@@ -125,7 +125,7 @@ def get_data(self, parsed_args):
                 )
 
 
-class ShowServer(command.OpenStackCommand, show.ShowOne):
+class ShowServer(show.ShowOne):
     """Show server command"""
 
     api = 'compute'
@@ -139,8 +139,8 @@ def get_parser(self, prog_name):
             help='Name or ID of server to display')
         return parser
 
-    def get_data(self, parsed_args):
-        self.log.debug('get_data(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         nova_client = self.app.client_manager.compute
         server = utils.find_resource(nova_client.servers, parsed_args.server)
 

openstackclient/identity/v2_0/endpoint.py

@@ -21,16 +21,16 @@
 
 import logging
 
+from cliff import command
 from cliff import lister
 from cliff import show
 
 from keystoneclient import exceptions as identity_exc
-from openstackclient.common import command
 from openstackclient.common import exceptions
 from openstackclient.common import utils
 
 
-class CreateEndpoint(command.OpenStackCommand, show.ShowOne):
+class CreateEndpoint(show.ShowOne):
     """Create endpoint command"""
 
     api = 'identity'
@@ -60,8 +60,8 @@ def get_parser(self, prog_name):
             help='New endpoint internal URL')
         return parser
 
-    def get_data(self, parsed_args):
-        self.log.debug('get_data(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         identity_client = self.app.client_manager.identity
         service = utils.find_resource(
             identity_client.services, parsed_args.service)
@@ -80,7 +80,7 @@ def get_data(self, parsed_args):
         return zip(*sorted(info.iteritems()))
 
 
-class DeleteEndpoint(command.OpenStackCommand):
+class DeleteEndpoint(command.Command):
     """Delete endpoint command"""
 
     api = 'identity'
@@ -94,14 +94,14 @@ def get_parser(self, prog_name):
             help='ID of endpoint to delete')
         return parser
 
-    def run(self, parsed_args):
-        self.log.debug('run(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         identity_client = self.app.client_manager.identity
         identity_client.endpoints.delete(parsed_args.endpoint)
         return
 
 
-class ListEndpoint(command.OpenStackCommand, lister.Lister):
+class ListEndpoint(lister.Lister):
     """List endpoint command"""
 
     api = 'identity'
@@ -116,8 +116,8 @@ def get_parser(self, prog_name):
             help='Additional fields are listed in output')
         return parser
 
-    def get_data(self, parsed_args):
-        self.log.debug('get_data(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         identity_client = self.app.client_manager.identity
         if parsed_args.long:
             columns = ('ID', 'Region', 'Service Name', 'Service Type',
@@ -139,7 +139,7 @@ def get_data(self, parsed_args):
                )
 
 
-class ShowEndpoint(command.OpenStackCommand, show.ShowOne):
+class ShowEndpoint(show.ShowOne):
     """Show endpoint command"""
 
     api = 'identity'
@@ -172,8 +172,8 @@ def get_parser(self, prog_name):
             help='Show all endpoints for this service')
         return parser
 
-    def get_data(self, parsed_args):
-        self.log.debug('get_data(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         identity_client = self.app.client_manager.identity
 
         if not parsed_args.all:

openstackclient/identity/v2_0/role.py

@@ -21,14 +21,14 @@
 
 import logging
 
+from cliff import command
 from cliff import lister
 from cliff import show
 
-from openstackclient.common import command
 from openstackclient.common import utils
 
 
-class AddRole(command.OpenStackCommand, show.ShowOne):
+class AddRole(show.ShowOne):
     """Add role to tenant:user"""
 
     api = 'identity'
@@ -55,8 +55,8 @@ def get_parser(self, prog_name):
         )
         return parser
 
-    def get_data(self, parsed_args):
-        self.log.debug('get_data(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         identity_client = self.app.client_manager.identity
         role = utils.find_resource(
             identity_client.roles, parsed_args.role)
@@ -75,7 +75,7 @@ def get_data(self, parsed_args):
         return zip(*sorted(info.iteritems()))
 
 
-class CreateRole(command.OpenStackCommand, show.ShowOne):
+class CreateRole(show.ShowOne):
     """Create new role"""
 
     api = 'identity'
@@ -90,8 +90,8 @@ def get_parser(self, prog_name):
         )
         return parser
 
-    def get_data(self, parsed_args):
-        self.log.debug('get_data(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         identity_client = self.app.client_manager.identity
         role = identity_client.roles.create(
             parsed_args.role_name,
@@ -102,7 +102,7 @@ def get_data(self, parsed_args):
         return zip(*sorted(info.iteritems()))
 
 
-class DeleteRole(command.OpenStackCommand):
+class DeleteRole(command.Command):
     """Delete existing role"""
 
     api = 'identity'
@@ -117,23 +117,23 @@ def get_parser(self, prog_name):
         )
         return parser
 
-    def run(self, parsed_args):
-        self.log.debug('run(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         identity_client = self.app.client_manager.identity
         role = utils.find_resource(
             identity_client.roles, parsed_args.role)
         identity_client.roles.delete(role.id)
         return
 
 
-class ListRole(command.OpenStackCommand, lister.Lister):
+class ListRole(lister.Lister):
     """List roles"""
 
     api = 'identity'
     log = logging.getLogger(__name__ + '.ListRole')
 
-    def get_data(self, parsed_args):
-        self.log.debug('get_data(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         columns = ('ID', 'Name')
         data = self.app.client_manager.identity.roles.list()
         return (columns,
@@ -144,7 +144,7 @@ def get_data(self, parsed_args):
                )
 
 
-class ListUserRole(command.OpenStackCommand, lister.Lister):
+class ListUserRole(lister.Lister):
     """List user-role assignments"""
 
     api = 'identity'
@@ -165,8 +165,8 @@ def get_parser(self, prog_name):
         )
         return parser
 
-    def get_data(self, parsed_args):
-        self.log.debug('get_data(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         columns = ('ID', 'Name', 'Tenant ID', 'User ID')
         identity_client = self.app.client_manager.identity
 
@@ -198,7 +198,7 @@ def get_data(self, parsed_args):
                )
 
 
-class RemoveRole(command.OpenStackCommand):
+class RemoveRole(command.Command):
     """Remove role from tenant:user"""
 
     api = 'identity'
@@ -225,8 +225,8 @@ def get_parser(self, prog_name):
         )
         return parser
 
-    def get_data(self, parsed_args):
-        self.log.debug('get_data(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         identity_client = self.app.client_manager.identity
         role = utils.find_resource(
             identity_client.roles, parsed_args.role)
@@ -241,7 +241,7 @@ def get_data(self, parsed_args):
         )
 
 
-class ShowRole(command.OpenStackCommand, show.ShowOne):
+class ShowRole(show.ShowOne):
     """Show single role"""
 
     api = 'identity'
@@ -256,8 +256,8 @@ def get_parser(self, prog_name):
         )
         return parser
 
-    def get_data(self, parsed_args):
-        self.log.debug('get_data(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         identity_client = self.app.client_manager.identity
         role = utils.find_resource(
             identity_client.roles, parsed_args.role)

openstackclient/identity/v2_0/service.py

@@ -21,16 +21,16 @@
 
 import logging
 
+from cliff import command
 from cliff import lister
 from cliff import show
 
 from keystoneclient import exceptions as identity_exc
-from openstackclient.common import command
 from openstackclient.common import exceptions
 from openstackclient.common import utils
 
 
-class CreateService(command.OpenStackCommand, show.ShowOne):
+class CreateService(show.ShowOne):
     """Create service command"""
 
     api = 'identity'
@@ -55,8 +55,8 @@ def get_parser(self, prog_name):
         )
         return parser
 
-    def get_data(self, parsed_args):
-        self.log.debug('get_data(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         identity_client = self.app.client_manager.identity
         service = identity_client.services.create(
             parsed_args.name,
@@ -69,7 +69,7 @@ def get_data(self, parsed_args):
         return zip(*sorted(info.iteritems()))
 
 
-class DeleteService(command.OpenStackCommand):
+class DeleteService(command.Command):
     """Delete service command"""
 
     api = 'identity'
@@ -84,14 +84,14 @@ def get_parser(self, prog_name):
         )
         return parser
 
-    def run(self, parsed_args):
-        self.log.debug('run(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         identity_client = self.app.client_manager.identity
         identity_client.services.delete(parsed_args.service)
         return
 
 
-class ListService(command.OpenStackCommand, lister.Lister):
+class ListService(lister.Lister):
     """List service command"""
 
     api = 'identity'
@@ -106,8 +106,8 @@ def get_parser(self, prog_name):
             help='Additional fields are listed in output')
         return parser
 
-    def get_data(self, parsed_args):
-        self.log.debug('get_data(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         if parsed_args.long:
             columns = ('ID', 'Name', 'Type', 'Description')
         else:
@@ -121,7 +121,7 @@ def get_data(self, parsed_args):
                )
 
 
-class ShowService(command.OpenStackCommand, show.ShowOne):
+class ShowService(show.ShowOne):
     """Show service command"""
 
     api = 'identity'
@@ -135,8 +135,8 @@ def get_parser(self, prog_name):
             help='Type, name or ID of service to display')
         return parser
 
-    def get_data(self, parsed_args):
-        self.log.debug('get_data(%s)' % parsed_args)
+    def take_action(self, parsed_args):
+        self.log.debug('take_action(%s)' % parsed_args)
         identity_client = self.app.client_manager.identity
         try:
             # search for the usual ID or name