Skip to content

add strings for landuses and government - #1609

Closed
novolife wants to merge 4 commits into
openstreetmap:mainfrom
novolife:strings
Closed

add strings for landuses and government#1609
novolife wants to merge 4 commits into
openstreetmap:mainfrom
novolife:strings

Conversation

@novolife

@novolife novolife commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

Description, Motivation & Context

Strings were added to the type of residential=*, industrial=*, military=* of landuse=* and government=* for ease of retrieval as well as translation. Selected some of the most commonly used and less controversial values for each key, especially landuse=industrial.

For military=*, since some values are not suitable for landuse=military, autoSuggestions is false.

As my English is not good, I hope that someone can help me to confirm that the content in the string is in accordance with American English.

Related issues

Links and data

Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Key:residential
https://wiki.openstreetmap.org/wiki/Key:industrial
https://wiki.openstreetmap.org/wiki/Key:military
https://wiki.openstreetmap.org/wiki/Key:government

Relevant tag usage stats:

https://taginfo.openstreetmap.org/keys/residential#values
https://taginfo.openstreetmap.org/keys/industrial#values
https://taginfo.openstreetmap.org/keys/military#values
https://taginfo.openstreetmap.org/keys/government#values

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions

Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@novolife

Copy link
Copy Markdown
Contributor Author

Test-Documentation

Preview links & Sidebar Screenshots

residential

ss1

industrial

ss2

military

ss4

government

ss3

Info-i

ss5

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

@tordans tordans added the field label Jun 23, 2025
Comment thread data/fields/industrial.json Outdated
Comment thread data/fields/industrial.json Outdated
@novolife
novolife requested a review from matkoniecz August 1, 2025 02:59
@novolife

Copy link
Copy Markdown
Contributor Author

Can someone please review this modified PR?

@matkoniecz

Copy link
Copy Markdown
Collaborator

closing and reopening to get preview working

@matkoniecz matkoniecz closed this Oct 21, 2025
@matkoniecz matkoniecz reopened this Oct 21, 2025
"strings": {
"options": {
"rural": "Rural",
"apartments": "Apartments",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this labels it is completely confusing when Urban and when Apartments and when Condominium and when Block is supposed to be used

BTW, after reading https://wiki.openstreetmap.org/wiki/Key%3Aresidential I am not entirely sure

Condominium is also not appearing at all at https://wiki.openstreetmap.org/wiki/Key%3Aresidential

@Kovoschiz Kovoschiz Feb 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • =condominium : Has been succeeded by condo= , which can be used on building=apartments easily. The word isn't standard worldwide. They may simply be called apartment. https://wiki.openstreetmap.org/wiki/Tag:residential=condominium
  • =block : I don't understand what this means either. Seems to be a unit of size, orthogonal to others.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

residential=* iteratively refines both landuse=residential and building=residential. Some values make sense for one but not the other, such as trailer_park and irregular_settlement. We might need to split it into two separate fields.

"urban": "Urban",
"condominium": "Condominium",
"trailer_park": "Trailer Park",
"irregular_settlement": "Irregular Settlement",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://wiki.openstreetmap.org/wiki/Key%3Aresidential mentions it is euphemism for slum, though "Irregular Settlement" has problem of not being really clear - I initially though that it refers to case of really bad urban design or lack thereof with houses wildly scattered across fields

Not sure is it just me being unaware that "Irregular Settlement" is euphemism for "Slum".

Using "Slum" or "Irregular Settlement (Slum)" label would break reason for using euphemism in the first place.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally and ideally, it's orthogonal too. There are 2k informal=yes used, which could be used on all structures (houses, apartment, trailers, tents, etc). https://taginfo.openstreetmap.org/keys/informal#combinations

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, the Indian and Latin American communities seem to have a soft consensus around using landuse=residential residential=irregular_settlement for these settlements, for lack of anything better. “Irregular settlement” is an established term particularly in India, where it corresponds to a quasi-legal designation. American English would call it a “shanty town”, though it might lose some nuance. “Slum” would be impolite or politically incorrect these days. Other terms like “informal settlement” or “favela” are also known in the dialect.

"irregular_settlement": "Irregular Settlement",
"detached": "Detached",
"terrace": "Terrace",
"university": "University",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and how you specify landuse=residential which is bunch of apartment buildings for students? One more orthogonal category.

Maybe residential= should be purged from iD presets if it is so badly designed? Or so badly organically grown?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #1958 (comment), I don’t think removing residential=* is feasible, unless you have a better suggestion for tagging apartment complexes (apartments) and mobile home parks (trailer_park).

@1ec5 1ec5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s a lot going on in here that should probably be broken out into multiple PRs. I left some feedback, mainly regarding the labels, which should be in American English as the development language of this repository.

"urban": "Urban",
"condominium": "Condominium",
"trailer_park": "Trailer Park",
"irregular_settlement": "Irregular Settlement",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, the Indian and Latin American communities seem to have a soft consensus around using landuse=residential residential=irregular_settlement for these settlements, for lack of anything better. “Irregular settlement” is an established term particularly in India, where it corresponds to a quasi-legal designation. American English would call it a “shanty town”, though it might lose some nuance. “Slum” would be impolite or politically incorrect these days. Other terms like “informal settlement” or “favela” are also known in the dialect.

"strings": {
"options": {
"rural": "Rural",
"apartments": "Apartments",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

residential=* iteratively refines both landuse=residential and building=residential. Some values make sense for one but not the other, such as trailer_park and irregular_settlement. We might need to split it into two separate fields.

"irregular_settlement": "Irregular Settlement",
"detached": "Detached",
"terrace": "Terrace",
"university": "University",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #1958 (comment), I don’t think removing residential=* is feasible, unless you have a better suggestion for tagging apartment complexes (apartments) and mobile home parks (trailer_park).

"social_security": "Social Security",
"customs": "Customs",
"environment": "Environment",
"cadaster": "Cadaster",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, this term is completely unknown in American English. Probably a more understandable term would be “Land Office” or “Land Registration Office”, but this isn’t a general term like cadaster/cadastre is in other dialects.

For context, the U.S. doesn’t have cadastral agencies per se. Most of the country follows the record title system. I think the responsibility for managing this system normally resides in what we’d tag as register_office. The six occurrences of government=cadaster in the U.S. are all over the place:

"register_office": "Register",
"legislative": "Legislative",
"transportation": "Transportation",
"ministry": "Ministry",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The American English term would be “department”. It would need to get translated to “ministry” in most of the other English localizations.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1ec5 thanks very much for checking is it in the correct English!

"public_service": "Public Service",
"tax": "Tax",
"register_office": "Register",
"legislative": "Legislative",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation claims that this is for the seat of legislature specifically, but given the tag name, I wouldn’t be surprised if it’s used more broadly for any office associated with a legislature or legislator in their official capacity.

"culture": "Culture",
"statistics": "Statistics",
"audit": "Audit",
"parliament": "Parliament"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this limited to countries that call their legislative body a parliament? Would these countries use government=legislative for more local legislative bodies?

"cadaster": "Cadaster",
"culture": "Culture",
"statistics": "Statistics",
"audit": "Audit",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"audit": "Audit",
"audit": "Auditor",

"single_family": "Single Family",
"urban": "Urban",
"condominium": "Condominium",
"trailer_park": "Trailer Park",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Trailer park” is a well-known term but somewhat politically incorrect these days. I documented this tag only because it was the most common among several tags at the time. “Mobile home park” is the less stigmatized term, which we’re already using for the preset:

"trailer_park": "Trailer Park",
"irregular_settlement": "Irregular Settlement",
"detached": "Detached",
"terrace": "Terrace",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a British term. In American English, we’re using “row of townhouses” for building=terrace, which implies “townhouses” for landuse=residential residential=terrace.

"name": "Row of Townhouses"

@matkoniecz matkoniecz added the waitfor-requested-changes This PR is waiting for an update to incorporate requested changes from a PR review. label Mar 8, 2026
@matkoniecz

Copy link
Copy Markdown
Collaborator

@novolife do you plan to address these comments or should it be closed as an abandoned PR?

@matkoniecz matkoniecz added the new-value adds value(s) to existing field label Mar 13, 2026
@matkoniecz matkoniecz closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

field new-value adds value(s) to existing field waitfor-requested-changes This PR is waiting for an update to incorporate requested changes from a PR review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants