add strings for landuses and government - #1609
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
Test-DocumentationPreview links & Sidebar ScreenshotsInfo-
|
|
Can someone please review this modified PR? |
|
closing and reopening to get preview working |
| "strings": { | ||
| "options": { | ||
| "rural": "Rural", | ||
| "apartments": "Apartments", |
There was a problem hiding this comment.
with this labels it is completely confusing when Urban and when Apartments and when Condominium and when Block is supposed to be used
BTW, after reading https://wiki.openstreetmap.org/wiki/Key%3Aresidential I am not entirely sure
Condominium is also not appearing at all at https://wiki.openstreetmap.org/wiki/Key%3Aresidential
There was a problem hiding this comment.
=condominium: Has been succeeded bycondo=, which can be used onbuilding=apartmentseasily. The word isn't standard worldwide. They may simply be called apartment. https://wiki.openstreetmap.org/wiki/Tag:residential=condominium=block: I don't understand what this means either. Seems to be a unit of size, orthogonal to others.
There was a problem hiding this comment.
residential=* iteratively refines both landuse=residential and building=residential. Some values make sense for one but not the other, such as trailer_park and irregular_settlement. We might need to split it into two separate fields.
| "urban": "Urban", | ||
| "condominium": "Condominium", | ||
| "trailer_park": "Trailer Park", | ||
| "irregular_settlement": "Irregular Settlement", |
There was a problem hiding this comment.
https://wiki.openstreetmap.org/wiki/Key%3Aresidential mentions it is euphemism for slum, though "Irregular Settlement" has problem of not being really clear - I initially though that it refers to case of really bad urban design or lack thereof with houses wildly scattered across fields
Not sure is it just me being unaware that "Irregular Settlement" is euphemism for "Slum".
Using "Slum" or "Irregular Settlement (Slum)" label would break reason for using euphemism in the first place.
There was a problem hiding this comment.
Personally and ideally, it's orthogonal too. There are 2k informal=yes used, which could be used on all structures (houses, apartment, trailers, tents, etc). https://taginfo.openstreetmap.org/keys/informal#combinations
There was a problem hiding this comment.
As far as I can tell, the Indian and Latin American communities seem to have a soft consensus around using landuse=residential residential=irregular_settlement for these settlements, for lack of anything better. “Irregular settlement” is an established term particularly in India, where it corresponds to a quasi-legal designation. American English would call it a “shanty town”, though it might lose some nuance. “Slum” would be impolite or politically incorrect these days. Other terms like “informal settlement” or “favela” are also known in the dialect.
| "irregular_settlement": "Irregular Settlement", | ||
| "detached": "Detached", | ||
| "terrace": "Terrace", | ||
| "university": "University", |
There was a problem hiding this comment.
and how you specify landuse=residential which is bunch of apartment buildings for students? One more orthogonal category.
Maybe residential= should be purged from iD presets if it is so badly designed? Or so badly organically grown?
There was a problem hiding this comment.
Per #1958 (comment), I don’t think removing residential=* is feasible, unless you have a better suggestion for tagging apartment complexes (apartments) and mobile home parks (trailer_park).
1ec5
left a comment
There was a problem hiding this comment.
There’s a lot going on in here that should probably be broken out into multiple PRs. I left some feedback, mainly regarding the labels, which should be in American English as the development language of this repository.
| "urban": "Urban", | ||
| "condominium": "Condominium", | ||
| "trailer_park": "Trailer Park", | ||
| "irregular_settlement": "Irregular Settlement", |
There was a problem hiding this comment.
As far as I can tell, the Indian and Latin American communities seem to have a soft consensus around using landuse=residential residential=irregular_settlement for these settlements, for lack of anything better. “Irregular settlement” is an established term particularly in India, where it corresponds to a quasi-legal designation. American English would call it a “shanty town”, though it might lose some nuance. “Slum” would be impolite or politically incorrect these days. Other terms like “informal settlement” or “favela” are also known in the dialect.
| "strings": { | ||
| "options": { | ||
| "rural": "Rural", | ||
| "apartments": "Apartments", |
There was a problem hiding this comment.
residential=* iteratively refines both landuse=residential and building=residential. Some values make sense for one but not the other, such as trailer_park and irregular_settlement. We might need to split it into two separate fields.
| "irregular_settlement": "Irregular Settlement", | ||
| "detached": "Detached", | ||
| "terrace": "Terrace", | ||
| "university": "University", |
There was a problem hiding this comment.
Per #1958 (comment), I don’t think removing residential=* is feasible, unless you have a better suggestion for tagging apartment complexes (apartments) and mobile home parks (trailer_park).
| "social_security": "Social Security", | ||
| "customs": "Customs", | ||
| "environment": "Environment", | ||
| "cadaster": "Cadaster", |
There was a problem hiding this comment.
By the way, this term is completely unknown in American English. Probably a more understandable term would be “Land Office” or “Land Registration Office”, but this isn’t a general term like cadaster/cadastre is in other dialects.
For context, the U.S. doesn’t have cadastral agencies per se. Most of the country follows the record title system. I think the responsibility for managing this system normally resides in what we’d tag as register_office. The six occurrences of government=cadaster in the U.S. are all over the place:
- Bureau of Land Management office – probably the closest thing we have to a cadastral registration office, but only for federal lands
- County GIS agency –
craft=cartographer? - County GIS agency
- County recorder’s office –
government=register_office? - County title bureau –
government=register_office? - City planning and zoning office –
government=planning?government=building_control?
| "register_office": "Register", | ||
| "legislative": "Legislative", | ||
| "transportation": "Transportation", | ||
| "ministry": "Ministry", |
There was a problem hiding this comment.
The American English term would be “department”. It would need to get translated to “ministry” in most of the other English localizations.
There was a problem hiding this comment.
@1ec5 thanks very much for checking is it in the correct English!
| "public_service": "Public Service", | ||
| "tax": "Tax", | ||
| "register_office": "Register", | ||
| "legislative": "Legislative", |
There was a problem hiding this comment.
This documentation claims that this is for the seat of legislature specifically, but given the tag name, I wouldn’t be surprised if it’s used more broadly for any office associated with a legislature or legislator in their official capacity.
| "culture": "Culture", | ||
| "statistics": "Statistics", | ||
| "audit": "Audit", | ||
| "parliament": "Parliament" |
There was a problem hiding this comment.
Is this limited to countries that call their legislative body a parliament? Would these countries use government=legislative for more local legislative bodies?
| "cadaster": "Cadaster", | ||
| "culture": "Culture", | ||
| "statistics": "Statistics", | ||
| "audit": "Audit", |
There was a problem hiding this comment.
| "audit": "Audit", | |
| "audit": "Auditor", |
| "single_family": "Single Family", | ||
| "urban": "Urban", | ||
| "condominium": "Condominium", | ||
| "trailer_park": "Trailer Park", |
There was a problem hiding this comment.
“Trailer park” is a well-known term but somewhat politically incorrect these days. I documented this tag only because it was the most common among several tags at the time. “Mobile home park” is the less stigmatized term, which we’re already using for the preset:
| "trailer_park": "Trailer Park", | ||
| "irregular_settlement": "Irregular Settlement", | ||
| "detached": "Detached", | ||
| "terrace": "Terrace", |
There was a problem hiding this comment.
This is a British term. In American English, we’re using “row of townhouses” for building=terrace, which implies “townhouses” for landuse=residential residential=terrace.
|
@novolife do you plan to address these comments or should it be closed as an abandoned PR? |





Description, Motivation & Context
Strings were added to the type of
residential=*,industrial=*,military=*oflanduse=*andgovernment=*for ease of retrieval as well as translation. Selected some of the most commonly used and less controversial values for each key, especiallylanduse=industrial.For
military=*, since some values are not suitable forlanduse=military,autoSuggestionsis false.As my English is not good, I hope that someone can help me to confirm that the content in the
stringis in accordance with American English.Related issues
Links and data
Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Key:residential
https://wiki.openstreetmap.org/wiki/Key:industrial
https://wiki.openstreetmap.org/wiki/Key:military
https://wiki.openstreetmap.org/wiki/Key:government
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.