Avoid duplicate drive-through field on post boxes - #2787
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. Use the Compare View on the Tagging Schema Browser (alpha) to see the changes of your PR against the FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
Test documentationPreview checks
SearchSearching for Mail Drop Box returned the expected preset in both locations. No edits were saved. |
|
Thanks for the PR! It is now merged but note that before you will see it in iD few things need to happen. iD tagging schema needs to get release (see https://github.com/openstreetmap/id-tagging-schema/releases - latest one mentioned there is just a draft). And later needs to be pulled in by iD. Thanks again for your contribution! If you are interested in making other one it would be really welcome! If you are looking for some easy and useful task look here. If you would try one of those and got stuck and existing documentation is insufficient - will free to ask for help! |
Description, Motivation & Context
The Mail Drop Box preset currently references both the US-specific
drive_through-USfield and the unrestricteddrive_throughfield. In the United States, the second field becomes visible after the tag is set, so the same key is rendered twice.This adds a location-scoped companion field for use in
moreFields. The US keeps its existing primary field, while the optional field remains available everywhere else. The new field cross-references the existing label so it does not introduce a duplicate translation string.Related issues
Closes #2762
Testing
npm run lintnpm run buildnpm test