Skip to content

Avoid duplicate drive-through field on post boxes - #2787

Merged
matkoniecz merged 1 commit into
openstreetmap:mainfrom
amannsan:fix/2762-post-box-drive-through
Aug 30, 2026
Merged

Avoid duplicate drive-through field on post boxes#2787
matkoniecz merged 1 commit into
openstreetmap:mainfrom
amannsan:fix/2762-post-box-drive-through

Conversation

@amannsan

Copy link
Copy Markdown
Contributor

Description, Motivation & Context

The Mail Drop Box preset currently references both the US-specific drive_through-US field and the unrestricted drive_through field. In the United States, the second field becomes visible after the tag is set, so the same key is rendered twice.

This adds a location-scoped companion field for use in moreFields. The US keeps its existing primary field, while the optional field remains available everywhere else. The new field cross-references the existing label so it does not introduce a duplicate translation string.

Related issues

Closes #2762

Testing

  • npm run lint
  • npm run build
  • npm test

@github-actions

Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

Use the Compare View on the Tagging Schema Browser (alpha) to see the changes of your PR against the main branch.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@amannsan

amannsan commented Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

Test documentation

Preview checks

  • United States test location
    • Selected the Mail Drop Box preset.
    • Drive-Through appeared exactly once before setting a value.
    • After setting it to Yes, the sidebar still showed exactly one Drive-Through field and the tag was drive_through=yes.
  • Outside-US test location
    • Drive-Through was not shown among the initial fields.
    • Searching Add field for Drive-Through returned the field, so it remains available outside the US.

Search

Searching for Mail Drop Box returned the expected preset in both locations.

No edits were saved.

@matkoniecz
matkoniecz merged commit 8e08cd9 into openstreetmap:main Aug 30, 2026
5 checks passed
@matkoniecz

Copy link
Copy Markdown
Collaborator

Thanks for the PR! It is now merged but note that before you will see it in iD few things need to happen.

iD tagging schema needs to get release (see https://github.com/openstreetmap/id-tagging-schema/releases - latest one mentioned there is just a draft). And later needs to be pulled in by iD.

Thanks again for your contribution! If you are interested in making other one it would be really welcome!

If you are looking for some easy and useful task look here. If you would try one of those and got stuck and existing documentation is insufficient - will free to ask for help!

@matkoniecz matkoniecz added bug Something isn't working preset labels Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working preset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate Drive-Through field on Mail Drop Box preset

2 participants