Skip to content

Add additional fields to climbing presets - #2793

Open
elnappo wants to merge 1 commit into
openstreetmap:mainfrom
elnappo:feature/climbing
Open

Add additional fields to climbing presets#2793
elnappo wants to merge 1 commit into
openstreetmap:mainfrom
elnappo:feature/climbing

Conversation

@elnappo

@elnappo elnappo commented Aug 31, 2026

Copy link
Copy Markdown

Description, Motivation & Context

This should make it easier to add climbing crags & routes to OSM with the correct tags. Tags are based on OSM wiki and my experience mapping climbing crags and alpine routes. I mainly use it in combination with Go Map!! to map climbing crags and routes, as the mobile reception is often to bad to edit it live. These tags are also used by the OpenClimbing project which is the main motivation for this PR.

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/openstreetmap/id-tagging-schema/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@matkoniecz

Copy link
Copy Markdown
Collaborator

That is quite a lot of tags.

Are these tags established in OSM tagging?

@github-actions

Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

Use the Compare View on the Tagging Schema Browser (alpha) to see the changes of your PR against the main branch.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@@ -0,0 +1,5 @@
{
"key": "climbing:aid",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have a good info-I help text for this one because it is apparently the right term for this, but still very niche.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a climber it's quite clear in my opinion but yes. Do you have an idea how to do that?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://wiki.openstreetmap.org/wiki/Key:climbing:aid is empty, it should contain information about the tag, when it applies, possible tag values and what they mean. The info help text I believe comes from the KeyDescription template on that wiki page.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The info help text I believe comes from the KeyDescription template on that wiki page.

sadly it comes from data items

@@ -0,0 +1,5 @@
{
"key": "climbing:dry",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a very good info-I for this one as well. Apparently, this means to use tooling for ice climbing, but on a dry rock.

{
"key": "climbing:grade:hueco",
"type": "combo",
"label": "Grade (Hueco / V-grade)",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The others have a good name that connects them to their yes/no field, but this one does not connect to data/fields/climbing/boulder.json yet.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean more then?

"prerequisiteTag": {
        "key": "climbing:boulder",
        "value": "yes"
    },

{
"key": "climbing:mixed",
"type": "check",
"label": "Mixed Climbing"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is ice+rock? We need a better name for this. Also are those routes seasonal?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thats the normal term for that, see https://en.wikipedia.org/wiki/Mixed_climbing Some but not all routes are seasonal. Higher in the mountains you can do that all year round.

@@ -0,0 +1,22 @@
{
"key": "climbing:rock",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really the schema and good practice to prefix this? Material is a standard field...
Those sub schema are a bit problematic is some cases when they establish not in fact just copy a main tag...

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That I don't know. I can only say that this tag is documented in the wiki, widely used and interpreted by openclimbing.org

Comment thread data/presets/climbing/crag.json Outdated
Comment on lines +21 to +22
"climbing/family",
"climbing/beginner"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about those. They feels very subjective. Like "smoothness", which required years of discussion to become useful and is still hard to tag. Are they critical here? How are the decisions being made?
IMO this is more of a value that belongs into the user feedback category of an app, like the personal star rating and those flags...

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove them, in climbing it's easy to agree on them in my experience. Currently they are described as:

  • The climbing crag/area is safe and suitable for families with children (easy access, safe terrain, space to play).
  • The climbing crag/area is suitable for beginners with easy access, safe terrain, good protection and mostly easy routes.

"climbing/multipitch",
"climbing/ice",
"climbing/mixed",
"climbing/dry",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we list them like that users will likely start adding values to each. Do we want that? And if not, can we discourage it...
We could make some separate presets.
We could try to use different fields that encode "nothing" as "no".
Or make some conditional?

Also when users fill out all, we will very likely end up with non logical combinations.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point but every "bigger" preset has man "no" "-" "yes" of type check and I don't see many things taged with multiple "no". I also haven't seen it in climbing related nodes yet. Is there a technical solution to that? Something like prerequisiteTag ? I'm open to add more logic here.

@tordans

tordans commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Can you please make a list of usage per tag. And of the wiki data item per tag. And of the wiki desc/help/clarity per tag. We will have to look at each to see if this is for the schema now...

This is the first mayor push for those tagging afaik so now is when alls the errors happen that we have to live with forever...

@elnappo

elnappo commented Sep 1, 2026

Copy link
Copy Markdown
Author

@matkoniecz your'e absolutely right, climbing has a lot of tags... (see wiki) One problem is that climbing has multiple major styles like lead, boulder, ice, dry, trad, ... even deep water soloing and each has it's own grading system. Some style also have multiple grading system like bouldering (2) and sport climbing (>5) which are all commonly used in different regions of the world.

@tordans In my opinion we can't to anything wrong with climbing styles and their grading as they are fundamental for tagging climbs and should not be omited. Here are stats for the other proposed tags:

Tag Count
climbing:hazard 168
climbing:inclination 1129
climbing:pitches 1237
climbing:rock 7625
climbing:family_friendly 75
climbing:beginner_friendly 6

I observed on me that not having the tags in e.g. Go Map!! leads to not use these tags at all because it's to annoying to write them every time while adding/updating multiple crags. Furthermore is feels like a chicken & egg problem establishing tags.

Just tagging @jvaclavik and @zbycz, creator of the first version of this preset and maintainers of OpenClimbing.

@matkoniecz

Copy link
Copy Markdown
Collaborator

climbing:beginner_friendly is barely used, subjective, https://wiki.openstreetmap.org/wiki/Climbing is not specifying clearly what would be threshold and is basically review in its current state...

at least this should be removed and other values also reviewed

@matkoniecz matkoniecz added the waitfor-requested-changes This PR is waiting for an update to incorporate requested changes from a PR review. label Sep 2, 2026
@elnappo

elnappo commented Sep 2, 2026

Copy link
Copy Markdown
Author

@matkoniecz agreed, it's removed. Thanks for your input!

@matkoniecz

Copy link
Copy Markdown
Collaborator

look like climbing:family_friendly has similar issue

@matkoniecz

Copy link
Copy Markdown
Collaborator

climbing:hazard is also having suspiciously low use, with some values used just few times worldwide and potentially quite subjective (though I am getting less sure here)

@@ -0,0 +1,34 @@
{
"key": "climbing:grade:hueco",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://wiki.openstreetmap.org/wiki/Climbing describes it as US-specific

no idea whether it should be appearing only in US, nowhere or actually everywhere

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two grading system for bouldering. heuco (mainly us) and france (mainly europe). The rest of the world is somewhere between. So is should be available worldwide.

@matkoniecz

Copy link
Copy Markdown
Collaborator

at least this should be removed and other values also reviewed

I am worried that while I can spot say climbing:family_friendly also being problematic, I cannot do this for other tagging schemas: please, review also other parts of PR and include only and solely established tagging schemas

This should make it easier to add climbing crags & routes to OSM with the correct tags. Tags are based on https://wiki.openstreetmap.org/wiki/Climbing.
@elnappo

elnappo commented Sep 2, 2026

Copy link
Copy Markdown
Author

I also removed climbing:family_friendly.

climbing:hazard is also having suspiciously low use, with some values used just few times worldwide and potentially > quite subjective (though I am getting less sure here)

I guess that's a good thing in this case ;) As this is kind of a "safety" feature, I would prefer to make the barrier to add these as low as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waitfor-requested-changes This PR is waiting for an update to incorporate requested changes from a PR review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants