Add additional fields to climbing presets - #2793
Conversation
|
That is quite a lot of tags. Are these tags established in OSM tagging? |
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. Use the Compare View on the Tagging Schema Browser (alpha) to see the changes of your PR against the FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "key": "climbing:aid", | |||
There was a problem hiding this comment.
We need to have a good info-I help text for this one because it is apparently the right term for this, but still very niche.
There was a problem hiding this comment.
As a climber it's quite clear in my opinion but yes. Do you have an idea how to do that?
There was a problem hiding this comment.
http://wiki.openstreetmap.org/wiki/Key:climbing:aid is empty, it should contain information about the tag, when it applies, possible tag values and what they mean. The info help text I believe comes from the KeyDescription template on that wiki page.
There was a problem hiding this comment.
The info help text I believe comes from the KeyDescription template on that wiki page.
sadly it comes from data items
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "key": "climbing:dry", | |||
There was a problem hiding this comment.
We need a very good info-I for this one as well. Apparently, this means to use tooling for ice climbing, but on a dry rock.
| { | ||
| "key": "climbing:grade:hueco", | ||
| "type": "combo", | ||
| "label": "Grade (Hueco / V-grade)", |
There was a problem hiding this comment.
The others have a good name that connects them to their yes/no field, but this one does not connect to data/fields/climbing/boulder.json yet.
There was a problem hiding this comment.
You mean more then?
"prerequisiteTag": {
"key": "climbing:boulder",
"value": "yes"
},
| { | ||
| "key": "climbing:mixed", | ||
| "type": "check", | ||
| "label": "Mixed Climbing" |
There was a problem hiding this comment.
So this is ice+rock? We need a better name for this. Also are those routes seasonal?
There was a problem hiding this comment.
Yes, thats the normal term for that, see https://en.wikipedia.org/wiki/Mixed_climbing Some but not all routes are seasonal. Higher in the mountains you can do that all year round.
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "key": "climbing:rock", | |||
There was a problem hiding this comment.
Is this really the schema and good practice to prefix this? Material is a standard field...
Those sub schema are a bit problematic is some cases when they establish not in fact just copy a main tag...
There was a problem hiding this comment.
That I don't know. I can only say that this tag is documented in the wiki, widely used and interpreted by openclimbing.org
| "climbing/family", | ||
| "climbing/beginner" |
There was a problem hiding this comment.
Not sure about those. They feels very subjective. Like "smoothness", which required years of discussion to become useful and is still hard to tag. Are they critical here? How are the decisions being made?
IMO this is more of a value that belongs into the user feedback category of an app, like the personal star rating and those flags...
There was a problem hiding this comment.
I can remove them, in climbing it's easy to agree on them in my experience. Currently they are described as:
- The climbing crag/area is safe and suitable for families with children (easy access, safe terrain, space to play).
- The climbing crag/area is suitable for beginners with easy access, safe terrain, good protection and mostly easy routes.
| "climbing/multipitch", | ||
| "climbing/ice", | ||
| "climbing/mixed", | ||
| "climbing/dry", |
There was a problem hiding this comment.
When we list them like that users will likely start adding values to each. Do we want that? And if not, can we discourage it...
We could make some separate presets.
We could try to use different fields that encode "nothing" as "no".
Or make some conditional?
Also when users fill out all, we will very likely end up with non logical combinations.
There was a problem hiding this comment.
I see your point but every "bigger" preset has man "no" "-" "yes" of type check and I don't see many things taged with multiple "no". I also haven't seen it in climbing related nodes yet. Is there a technical solution to that? Something like prerequisiteTag ? I'm open to add more logic here.
|
Can you please make a list of usage per tag. And of the wiki data item per tag. And of the wiki desc/help/clarity per tag. We will have to look at each to see if this is for the schema now... This is the first mayor push for those tagging afaik so now is when alls the errors happen that we have to live with forever... |
|
@matkoniecz your'e absolutely right, climbing has a lot of tags... (see wiki) One problem is that climbing has multiple major styles like lead, boulder, ice, dry, trad, ... even deep water soloing and each has it's own grading system. Some style also have multiple grading system like bouldering (2) and sport climbing (>5) which are all commonly used in different regions of the world. @tordans In my opinion we can't to anything wrong with climbing styles and their grading as they are fundamental for tagging climbs and should not be omited. Here are stats for the other proposed tags:
I observed on me that not having the tags in e.g. Go Map!! leads to not use these tags at all because it's to annoying to write them every time while adding/updating multiple crags. Furthermore is feels like a chicken & egg problem establishing tags. Just tagging @jvaclavik and @zbycz, creator of the first version of this preset and maintainers of OpenClimbing. |
|
at least this should be removed and other values also reviewed |
e8547e9 to
dacde2f
Compare
|
@matkoniecz agreed, it's removed. Thanks for your input! |
|
look like |
|
|
| @@ -0,0 +1,34 @@ | |||
| { | |||
| "key": "climbing:grade:hueco", | |||
There was a problem hiding this comment.
https://wiki.openstreetmap.org/wiki/Climbing describes it as US-specific
no idea whether it should be appearing only in US, nowhere or actually everywhere
There was a problem hiding this comment.
There are two grading system for bouldering. heuco (mainly us) and france (mainly europe). The rest of the world is somewhere between. So is should be available worldwide.
I am worried that while I can spot say |
This should make it easier to add climbing crags & routes to OSM with the correct tags. Tags are based on https://wiki.openstreetmap.org/wiki/Climbing.
dacde2f to
232d531
Compare
|
I also removed
I guess that's a good thing in this case ;) As this is kind of a "safety" feature, I would prefer to make the barrier to add these as low as possible. |
Description, Motivation & Context
This should make it easier to add climbing crags & routes to OSM with the correct tags. Tags are based on OSM wiki and my experience mapping climbing crags and alpine routes. I mainly use it in combination with Go Map!! to map climbing crags and routes, as the mobile reception is often to bad to edit it live. These tags are also used by the OpenClimbing project which is the main motivation for this PR.
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.