fix(protocol): encode weekly expansion in store summary

Write the 15.25 Cyclopedia store-summary fields in the decoded order: Prey slots, Prey wildcards, Permanent Weekly Task Expansion, collection tokens, Charm Expansion, and hirelings.

Stop folding the legacy hunting-task slot into the Prey counter and source the dedicated expansion byte from the Task Board KV without changing the packet boundary.

Validation: lua tests/lua/test_taskboard_store_summary_wire.lua (1 passed, 0 failed); clang-format check passed for the changed lines.

Author: dudantas

src/server/network/protocol/protocolgame.cpp

@@ -5142,18 +5142,14 @@ void ProtocolGame::sendCyclopediaCharacterStoreSummary() {
 	    slotP && slotP->state != PreyDataState_Locked) {
 		preySlotsUnlocked++;
 	}
-	// Task hunting third slot unlocked
-	if (const auto &slotH = player->getTaskHuntingSlotById(PreySlot_Three);
-	    slotH && slotH->state != PreyTaskDataState_Locked) {
-		preySlotsUnlocked++;
-	}
-	msg.addByte(preySlotsUnlocked); // getPreySlotById + getTaskHuntingSlotById
+	msg.addByte(preySlotsUnlocked);
 
 	msg.addByte(cyclopediaSummary.m_preyWildcards); // getPreyCardsObtained
+	const auto weeklyExpansion = player->kv()->scoped("task-board")->scoped("general")->get("weekly-expansion-unlocked");
+	msg.addByte(weeklyExpansion && weeklyExpansion->get<bool>() ? 0x01 : 0x00);
 	msg.addByte(cyclopediaSummary.m_instantRewards); // getRewardCollectionObtained
 	msg.addByte(player->hasCharmExpansion() ? 0x01 : 0x00);
 	msg.addByte(cyclopediaSummary.m_hirelings); // getHirelingsObtained
-	msg.addByte(0x00); // Reserved current-client store summary field
 
 	std::vector<uint16_t> m_hSkills;
 	for (const auto &[skillId, skillName] : g_game().getHirelingSkills()) {

tests/lua/test_taskboard_store_summary_wire.lua

@@ -0,0 +1,23 @@
+-- Standalone source contract for the current-client store summary packet.
+-- Run from the repository root with: lua tests/lua/test_taskboard_store_summary_wire.lua
+
+local protocolFile = assert(io.open("src/server/network/protocol/protocolgame.cpp", "r"))
+local protocol = protocolFile:read("*a")
+protocolFile:close()
+
+local summary = assert(protocol:match("void ProtocolGame::sendCyclopediaCharacterStoreSummary%(%)%s*{(.-)std::vector<uint16_t> m_hSkills"))
+local preySlots = assert(summary:find("msg.addByte(preySlotsUnlocked);", 1, true))
+local preyWildcards = assert(summary:find("msg.addByte(cyclopediaSummary.m_preyWildcards);", 1, true))
+local weeklyExpansion = assert(summary:find('get("weekly-expansion-unlocked")', 1, true))
+local collectionTokens = assert(summary:find("msg.addByte(cyclopediaSummary.m_instantRewards);", 1, true))
+local charmExpansion = assert(summary:find("msg.addByte(player->hasCharmExpansion() ? 0x01 : 0x00);", 1, true))
+local hirelings = assert(summary:find("msg.addByte(cyclopediaSummary.m_hirelings);", 1, true))
+
+assert(preySlots < preyWildcards)
+assert(preyWildcards < weeklyExpansion)
+assert(weeklyExpansion < collectionTokens)
+assert(collectionTokens < charmExpansion)
+assert(charmExpansion < hirelings)
+assert(summary:find("getTaskHuntingSlotById", 1, true) == nil)
+
+print("\n1 passed, 0 failed")