Skip to content

opentracing-spring-cloud-redis-starter RedisClusterConnection wrapped in TracingRedisConnection #336

Description

@bivab

The Redis aspect will wrap all RedisConnection objects returned by the intercepted call in TracingRedisConnection, although Jedis (not sure if Lettuce too) can return RedisClusterConnection from the getConnection call which should be wrapped as TracingRedisClusterConnection.

In spring, using the actuator, this leads to issues with for instance the Redis health indicator that behaves differently for clustered and non-clustered modes.

See this repository for an example: https://github.com/bivab/opentracing-spring-cloud-redis-starter-demo

Including or excluding opentracing-spring-cloud-redis-starter in pom.xml will lead to different results.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions