Commit 7569893
authored
TOOLS: fix in-place ReduceScatter buffer size (#1342)
## Summary
- use the full source count for in-place ReduceScatter
- allocate the in-place destination from the count passed to UCC
## Rationale
For ReduceScatter, the generator destination count describes one rank's
output
shard, while the source count describes the full input. In-place
operation uses
the destination as the source buffer, so passing the destination shard
count
makes the operation smaller than the Count/Size reported by
`ucc_perftest`.
## Testing
- built UCC with the change
- verified in-place and out-of-place collective arguments at 2, 4, and 8
ranks
with host/CUDA memory and TL/UCP ring/K-nomial
- ran 10,240 MPI-reference ReduceScatter cases: all passed1 parent d718c7d commit 7569893
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
| 58 | + | |
58 | 59 | | |
59 | 60 | | |
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
63 | 64 | | |
64 | | - | |
| 65 | + | |
65 | 66 | | |
66 | 67 | | |
67 | 68 | | |
| |||
0 commit comments