UCS/SOCKET: simple input parameter naming fix

[dschervov]

What?

Fix the function definition/implementation input parameter different naming.

Why?

This makes code more readable (and beautiful).

[svc-nvidia-pr-review]

🤖 Starting review — findings will be posted here when done.

[svc-nvidia-pr-review]

minor: silent_bind reads broader than the behavior — only the EADDRINUSE case is silenced. Fine given the doc comment clarifies it, just flagging.

[svc-nvidia-pr-review]

Confirm with the author that the header change to silent_bind lands together with the .c definition in the same PR — the header change isn't shown in the reviewed diff snippet, and they must land together, otherwise the intent of the rename is incomplete.

[dschervov]

Confirm with the author that the header change to silent_bind lands together with the .c definition in the same PR — the header change isn't shown in the reviewed diff snippet, and they must land together, otherwise the intent of the rename is incomplete.

Because its already like this, my robot friend! Look:

/**
 * Initialize a TCP server.
 * Open a socket, bind a sockaddr to that socket and start listening on it for 
 * incoming connection requests.
 *
 * @param [in]  saddr             Sockaddr for the server to listen on. 
 *                                If the port number inside is set to zero -
 *                                use a random port.
 * @param [in]  socklen           Size of saddr.
 * @param [in]  backlog           Length of the queue for pending connections -
 *                                for the listen() call.
 * @param [in]  silent_bind       Whether or not to print error message on bind
 *                                failure with EADDRINUSE.
 * @param [in]  reuse_addr        Whether or not to allow the socket to use an
 *                                address that is already in use and was not 
 *                                released by another socket yet.
 * @param [out] listen_fd         The fd that belongs to the server.
 *
 * @return UCS_OK on success or an error code on failure.
 */
ucs_status_t ucs_socket_server_init(const struct sockaddr *saddr, socklen_t socklen,
                                    int backlog, int silent_bind, int reuse_addr,
                                    int *listen_fd);

[svc-nvidia-pr-review]

🤖 Starting review — findings will be posted here when done.

[svc-nvidia-pr-review]

🤖 Review complete — no issues found.