Skip to content

UCS/SOCKET: simple input parameter naming fix #11859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dschervov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

UCS/SOCKET: simple input parameter naming fix #11859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ucs/sys/sock.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ ucs_status_t ucs_socket_set_buffer_size(int fd, size_t sockopt_sndbuf,
}

@svc-nvidia-pr-review svc-nvidia-pr-review Aug 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: silent_bind reads broader than the behavior — only the EADDRINUSE case is silenced. Fine given the doc comment clarifies it, just flagging.


ucs_status_t ucs_socket_server_init(const struct sockaddr *saddr, socklen_t socklen,
int backlog, int silent_err_in_use,
int backlog, int silent_bind,

@svc-nvidia-pr-review svc-nvidia-pr-review Sep 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent parameter name. The header sock.h was renamed to silent_bind, but the .c definition still uses silent_err_in_use. This compiles (C ignores prototype vs. definition parameter-name mismatches), but the rename is incomplete and leaves the two files inconsistent, defeating the purpose of the PR.

Suggested change
int backlog, int silent_bind,
int backlog, int silent_bind,

Pls also rename the use on the errno == EADDRINUSE check below; the header already uses silent_bind, so the definition here is left inconsistent.

@dschervov dschervov Sep 1, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are talking about? I do just that!

@svc-nvidia-pr-review svc-nvidia-pr-review Sep 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the header was renamed to silent_bind but the definition here still uses silent_err_in_use. pls rename here too so the header and implementation match.

int reuse_addr, int *listen_fd)
{
int so_reuse_optval = 1;
Expand Down Expand Up @@ -493,7 +493,7 @@ ucs_status_t ucs_socket_server_init(const struct sockaddr *saddr, socklen_t sock

ret = bind(fd, saddr, socklen);
if (ret < 0) {
if ((errno == EADDRINUSE) && silent_err_in_use) {
if ((errno == EADDRINUSE) && silent_bind) {

@svc-nvidia-pr-review svc-nvidia-pr-review Sep 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent parameter name; rename the use on the errno == EADDRINUSE check to match the header's silent_bind.

Suggested change
if ((errno == EADDRINUSE) && silent_bind) {
if ((errno == EADDRINUSE) && silent_bind) {

@dschervov dschervov Sep 1, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are being silly, mr. Robot

@svc-nvidia-pr-review svc-nvidia-pr-review Sep 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ((errno == EADDRINUSE) && silent_bind) {
if ((errno == EADDRINUSE) && silent_bind) {

complete the rename in the function body as well.

bind_log_level = UCS_LOG_LEVEL_DEBUG;
} else {
bind_log_level = UCS_LOG_LEVEL_ERROR;
Expand Down