UCS/SYS/NETLINK: Add netlink gtest - #11862
Conversation
|
🤖 Starting review — findings will be posted here when done. |
|
|
||
| if (ucs_netlink_is_best_route(ndev_index, sa_remote)) { | ||
| /* This interface has the best route */ | ||
| if (ucs_netlink_route_matches(ndev_index, sa_remote, |
There was a problem hiding this comment.
Behavior broadening for RoCE not covered by an integration/behavior note. The old code only accepted this GID when the interface had the globally-best route (then fell back to loopback/local). RELAXED now accepts any non-default matching route on the interface even when another interface has a more specific route. This is a real reachability-policy change; worth a one-line "why" in the PR description per REVIEW.md. Not a code bug.
|
Scope: this PR mixes the route-table refactor with a behavior change (new RELAXED policy for RoCE). Per REVIEW.md, feature PRs must not refactor unrelated code. Since the refactor is what makes the new behavior unit-testable it's defensible, but please clarify in the description that RoCE reachability is intentionally broadened and the extraction is needed to unit-test it. |
2 participants
What?
Added netlink gtests.
Based on
fix/rc-gda-reachability#11835.