Skip to content

minidlna: fix build with FFmpeg 7 and later - #30563

Open
marcinmajsc wants to merge 1 commit into
openwrt:masterfrom
marcinmajsc:minidlna-fix
Open

marcinmajsc wants to merge 1 commit into
openwrt:masterfrom
marcinmajsc:minidlna-fix

Conversation

@marcinmajsc

Copy link
Copy Markdown
Contributor

FFmpeg 7 removed AVCodecParameters.channels, causing MiniDLNA 1.3.3 to fail to compile when reading audio channel counts.

Add an OpenWrt package patch to use ch_layout.nb_channels with libavcodec 61 and later. Retain the existing channels field access for older versions.

📦 Package Details

Maintainer: Alexandru Ardelean ardeleanalex@gmail.com

Description:
MiniDLNA (aka ReadyDLNA) is server software with the aim of being fully compliant with DLNA/UPnP-AV clients.


🧪 Run Testing Details

  • OpenWrt Version: master
  • OpenWrt Target/Subtarget: cortexa9/mvebu
  • OpenWrt Device: WRT1200AC

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@marcinmajsc
marcinmajsc marked this pull request as draft September 19, 2026 23:02
@marcinmajsc
marcinmajsc marked this pull request as ready for review September 19, 2026 23:55

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit.


Generated by Claude Code

@@ -0,0 +1,22 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The all-zero SHA plus the placeholder 12:00:00 date fabricate a git header, so this reads as a cherry-pick of commit 0000000 when nothing was cherry-picked. The comparable ffmpeg-compat patch in this feed, multimedia/gst1-libav/patches/001-gst-libav-Fix-build-failure-with-FFmpeg-9.0.patch,`` carries the real upstream SHA and a link to the upstream MR. Is there an existing ReadyMedia commit for this that should be backported instead — and if not, can the fake From/`Date` lines be dropped in favour of an upstream reference or `Upstream-Status`?


Generated by Claude Code

FFmpeg 7 removed AVCodecParameters.channels, causing MiniDLNA 1.3.3
to fail to compile when reading audio channel counts.

Add an OpenWrt package patch to use ch_layout.nb_channels with
libavcodec 61 and later. Retain the existing channels field access
for older versions.

Signed-off-by: Marcin Maj <marcinmajsc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants