Repository navigation
Commit 9a04d57
[FSSDK-12919] Replace deprecated hub CLI with gh in release workflow (#467)
* [FSSDK-12919] Replace deprecated hub CLI with gh in release workflow
Agent GitHub releases were shipping with no binary assets because the
release workflow attached generate_secret via the deprecated `hub` CLI,
which is not installed on GitHub-hosted runners (hub: command not found).
Replace `hub` with `gh` (preinstalled on all runners):
- ci_attach_generate_secret.sh: `hub release edit -a` -> `gh release upload --clobber`
- new ci_create_github_release.sh: gh-based, idempotent replacement for
travisci-tools/release_github_v2.sh (same CHANGELOG parsing)
- workflow: drop install_hub.sh steps + unused travisci-tools checkouts;
`hub release download -i` -> `gh release download -p`
https://optimizely-ext.atlassian.net/browse/FSSDK-12919
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* [FSSDK-12919] Address review: harden release script, drop unused HOME
- ci_create_github_release.sh: set -eo pipefail; guard missing CHANGELOG.md;
quote CHANGELOG; write notes to a temp file and use --notes-file so
backticks/$ in the changelog body aren't shell-parsed
- agent.yml: remove now-unused HOME='home/runner' override
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>1 parent dd1e69c commit 9a04d57
3 files changed
Lines changed: 82 additions & 41 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | 173 | | |
182 | 174 | | |
183 | 175 | | |
| |||
190 | 182 | | |
191 | 183 | | |
192 | 184 | | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | 185 | | |
201 | 186 | | |
202 | 187 | | |
203 | 188 | | |
204 | 189 | | |
205 | 190 | | |
206 | | - | |
207 | | - | |
| 191 | + | |
208 | 192 | | |
209 | 193 | | |
210 | 194 | | |
211 | 195 | | |
212 | 196 | | |
213 | 197 | | |
214 | 198 | | |
215 | | - | |
216 | | - | |
217 | | - | |
| 199 | + | |
| 200 | + | |
218 | 201 | | |
219 | 202 | | |
220 | 203 | | |
| |||
244 | 227 | | |
245 | 228 | | |
246 | 229 | | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | 230 | | |
256 | 231 | | |
257 | 232 | | |
258 | 233 | | |
259 | 234 | | |
260 | 235 | | |
261 | 236 | | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | 237 | | |
271 | 238 | | |
272 | 239 | | |
| |||
276 | 243 | | |
277 | 244 | | |
278 | 245 | | |
279 | | - | |
| 246 | + | |
| 247 | + | |
280 | 248 | | |
281 | 249 | | |
282 | 250 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
0 commit comments