Repository navigation
Commit f1a319b
[FSSDK-13266] Update dependency constraints for json-schema and murmurhash (#298)
* [FSSDK-13266] Update dependency constraints for json-schema and murmurhash
Allow justinrainbow/json-schema v6.x and lastguest/murmurhash v2.x
to support newer versions of these dependencies.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* [FSSDK-13266] Fix compatibility with murmurhash v2 and json-schema v6
murmurhash v2 removed the global murmurhash3_int() function in favor of
a static class method. Add a function_exists() check to support both APIs.
json-schema v6 deprecated check() in favor of validate(). Switch to the
new method for forward compatibility.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* [FSSDK-13266] Fix: Add check() fallback for older json-schema versions
validate() does not exist in json-schema v1.6 and v2.x. Use
method_exists() to call validate() when available and fall back
to check() for older versions.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* Add latest dependency CI coverage
Co-authored-by: Tamara-Barum <88795935+Tamara-Barum@users.noreply.github.com>
* Limit permissions for dependency CI job
Co-authored-by: Tamara-Barum <88795935+Tamara-Barum@users.noreply.github.com>
* [FSSDK-13266] Address PR review feedback
- Fix Validator.php comment to accurately describe json-schema version
history (validate() added in v5, check() deprecated in v6)
- De-duplicate bitmask operation in Bucketer.php
- Change murmurhash constraint from ^2.0 to ^2.1 (2.0.0 requires PHP 7)
- Regenerate composer.lock to match updated constraints
- Remove premature CHANGELOG 4.0.4 entry (belongs in release-prep PR)
- Add CI job to test with latest dependency versions (PHP 8.1 + 8.2)
with version assertion to verify v6/v2 actually resolved
- Add edge-case bucketing test keys (empty string, UTF-8)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* [FSSDK-13266] Fix: Split composer show into separate commands
composer show does not accept multiple package names as positional
arguments — the second name was parsed as a version constraint.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* [FSSDK-13266] Address alexjoeyyong review: simplify Validator and CI job
- Revert Validator.php to use check() directly — it works in all allowed
versions (1.6 through 6.x) and the v6 deprecation is docblock-only
- Remove redundant composer install step from latest-deps CI job
- Remove redundant composer show lines — the php -r gate already echoes
and asserts the resolved versions
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* [FSSDK-13266] Add 4.0.4 CHANGELOG entry and tighten CI murmurhash gate
Re-add the user-facing CHANGELOG entry and align the CI version check
with the ^2.1 murmurhash constraint.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* [FSSDK-13266] Remove 4.0.4 CHANGELOG entry
The release entry belongs in the separate release-prep PR alongside
the SDK_VERSION bump.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>1 parent be16fd9 commit f1a319b
5 files changed
Lines changed: 55 additions & 11 deletions
File tree
- .github/workflows
- src/Optimizely
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
67 | 98 | | |
68 | 99 | | |
69 | 100 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | | - | |
| 20 | + | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
76 | 80 | | |
77 | 81 | | |
78 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
91 | 100 | | |
92 | 101 | | |
93 | 102 | | |
| |||
0 commit comments