Skip to content

Commit 0a7dc91

Browse files
committed
[AI-FSSDK] [FSSDK-12958] Keep deprecated holdout_decision key alongside list
1 parent 2067caf commit 0a7dc91

2 files changed

Lines changed: 17 additions & 0 deletions

File tree

‎optimizely/decision_service.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ class VariationResult(TypedDict):
6565

6666

6767
class _DecisionResultOptional(TypedDict, total=False):
68+
holdout_decision: Decision # Deprecated: first entry of holdout_decisions.
6869
holdout_decisions: List[Decision]
6970

7071

@@ -807,6 +808,7 @@ def get_decision_for_flag(
807808
}
808809
if holdout_decisions:
809810
result['holdout_decisions'] = holdout_decisions
811+
result['holdout_decision'] = holdout_decisions[0]
810812
return result
811813

812814
local_holdout = self._get_local_holdout_decision(
@@ -842,6 +844,7 @@ def get_decision_for_flag(
842844
}
843845
if holdout_decisions:
844846
result['holdout_decisions'] = holdout_decisions
847+
result['holdout_decision'] = holdout_decisions[0]
845848
return result
846849

847850
if global_holdout_result is not None:
@@ -879,6 +882,7 @@ def get_decision_for_flag(
879882
}
880883
if holdout_decisions:
881884
final_result['holdout_decisions'] = holdout_decisions
885+
final_result['holdout_decision'] = holdout_decisions[0]
882886
return final_result
883887

884888
def _get_local_holdout_decision(

‎tests/test_decision_service_holdout.py‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1774,6 +1774,19 @@ def test_local_holdout_hits_on_several_rules_send_several_holdout_events(self):
17741774
self.assertEqual(final_call.args[5], str(enums.DecisionSources.ROLLOUT))
17751775
self.assertIsNone(final_call.args[2])
17761776

1777+
def test_deprecated_holdout_decision_is_first_of_holdout_decisions(self):
1778+
opt = self._make_opt_exp_with_rollout([
1779+
_holdout('lh_exp', 'for_exp', included_rules=['111127']),
1780+
_holdout('lh_del', 'for_del', included_rules=['211147']),
1781+
])
1782+
config = opt.config_manager.get_config()
1783+
1784+
result = self._decision_svc().get_decision_for_flag(
1785+
config.get_feature_from_key('test_feature_in_experiment'), opt.create_user_context('test_user', {}), config
1786+
)
1787+
self.assertEqual([d.experiment.key for d in result['holdout_decisions']], ['for_exp', 'for_del'])
1788+
self.assertIs(result['holdout_decision'], result['holdout_decisions'][0])
1789+
17771790
def test_one_local_holdout_on_two_rules_sends_two_holdout_events(self):
17781791
"""A single local holdout targeting two rules is hit on each rule and sends an event per hit."""
17791792
opt = self._make_opt_exp_with_rollout([

0 commit comments

Comments
 (0)