Raise the compile() unrecognised-flags error with its message

checkFlags called PRaiseNode.raiseStatic(this, ValueError, null,
NO_VALUE, UNRECOGNIZED_FLAGS, EMPTY_OBJECT_ARRAY), mirroring the
argument order of the old internal execute(). No public overload takes
those arguments, so the call bound to raiseStatic(Node, type, message,
Object...) with a null message and the intended message as a format
argument. The ValueError could be caught, but str(), repr() or .args on
it formatted the null message and threw a Java NullPointerException.

Use the message overload, as checkOptimize next to it does. CPython
raises ValueError("compile(): unrecognised flags").

Signed-off-by: Jeongseop Lim <jeongseop_lim@korea.ac.kr>

Author: jseop-lim

graalpython/com.oracle.graal.python.test/src/tests/test_parser.py

@@ -64,6 +64,15 @@ def test_incomplete_input_error():
             assert False, "SyntaxError was not raised"
 
 
+def test_compile_unrecognised_flags_message():
+    try:
+        compile("1", "<input>", "exec", 0x7fffffff)
+    except ValueError as e:
+        assert str(e) == "compile(): unrecognised flags"
+    else:
+        assert False, "ValueError was not raised"
+
+
 def test_lambdas_as_function_default_argument_values():
     globs = {}
     exec("""

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinFunctions.java

@@ -1143,7 +1143,7 @@ private void checkOptimize(int optimize, Object kwOptimize) throws PException {
         @TruffleBoundary
         private void checkFlags(int flags) {
             if ((flags & ~(PyCF_MASK | PyCF_MASK_OBSOLETE | PyCF_COMPILE_MASK)) != 0) {
-                throw PRaiseNode.raiseStatic(this, ValueError, null, NO_VALUE, ErrorMessages.UNRECOGNIZED_FLAGS, PythonUtils.EMPTY_OBJECT_ARRAY);
+                throw PRaiseNode.raiseStatic(this, ValueError, ErrorMessages.UNRECOGNIZED_FLAGS);
             }
         }