refactor(fail-fast): surface invalid JSON API responses - #13
Open
Gabrielgvl wants to merge 1 commit into
Open
Conversation
Malformed API payloads were previously parsed as empty data, which masked service contract failures and made debugging ambiguous. This change throws a typed invalid-response error before fallback rendering while preserving 204 and empty-body success semantics.
Codex PR reviewResult: ❌ blocking Top findings
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Malformed API responses were parsed as
nulland then rendered as empty/default payloads. That masked a real service contract failure and made plugin failures look like degraded success.Root cause
parseJsonSafe(response)caught JSON parse errors and returnednullfor both successful and error responses.Refactor
OrbioInvalidResponseErrorfor malformed JSON response bodies.runGuarded(...).Risk
Low: only non-empty malformed JSON responses change behavior; valid JSON, 204, and empty-body success paths remain unchanged.
Validation
pnpm --filter @orbio/orbio-openclaw test— 45 passedpnpm --filter @orbio/orbio-openclaw verify— passed (lint, typecheck, coverage 99.11% statements / 96.11% branches, env audit, build)