chore(benchmark): archive the unreferenced SWE-bench Rust runner - #1173
Merged
Conversation
The 2026-08-16 SWE-bench UI archival left `src-tauri/src/benchmark/` compiled and registered with no frontend caller, and recorded that a backend-only removal should follow. This is that removal. Moves the runner (3,542 LOC: SWE-bench dataset/task loading, run and agent-batch orchestration, Docker evaluation, preflight, retention, history) to `.archive/src-tauri/src/benchmark/` and unwires it: 13 `benchmark_*` registrations, `pub mod benchmark;`, the handler-list `use` scope, and the exit-time evaluator-termination call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 2026-08-16 SWE-bench "Benchmark (Beta)" archival parked the whole frontend
surface — panel, run builder, tab renderer, store atoms,
benchmarkApiclient,E2E helpers and specs — but deliberately left the Rust side in place. Its own
.archive/README.mdentry recorded the consequence:Since then
src-tauri/src/benchmark/(3,542 LOC) has compiled into every buildand registered 13
benchmark_*Tauri commands that nothing can call. A sweep ofthe 1,019 entries in
src-tauri/src/commands/handler_list.incagainst everynon-Rust source file in the repository confirms it: none of the 13 appears in
src/,tests/, orsrc-tauri/capabilities/, and no Rust caller reaches themodule either — the only inbound edge outside the module was the exit-time
evaluator cleanup in
app/lifecycle.rs, which exists solely to reap processesthe (now unreachable) runner would have spawned.
This is the backend-only PR that entry called for.
Solution
git mv src-tauri/src/benchmark/ .archive/src-tauri/src/benchmark/, matchingthe existing archival convention: paths mirror their original location, nothing
under
.archive/is compiled or bundled, and restoring is a reversegit mv.Unwired in place:
src-tauri/src/commands/handler_list.inc— dropped the 13benchmark::benchmark_*registrations and their section commentsrc-tauri/src/lib.rs— droppedpub mod benchmark;src-tauri/src/app/builder.rs— droppedbenchmarkfrom theuse crate::{…}scope that
handler_list.incresolves againstsrc-tauri/src/app/lifecycle.rs— dropped theuse crate::benchmark;importand the exit-time
benchmark::terminate_running_evaluators_sync()callResulting invariant: the app's IPC surface no longer advertises a
benchmark_*command, and no code path can spawn a SWE-bench evaluator subprocess, so the
exit-time reaper it guarded has nothing left to reap.
.archive/README.md's SWE-bench section is updated so the entry that asked forthis removal now records that it happened, together with the in-place edits
needed to reverse it.
Not the Housekeeper token benchmark (
housekeeper_token_benchmark,rpc.validation.housekeeperTokenBenchmark) — a different feature, untouched andstill registered.
Potential risks
the app data dir; those files are simply no longer read. Nothing is deleted
from disk by this change, so restoring the module restores access to them.
frontend build that still called them would now fail at runtime instead of
succeeding — but the callers were archived in the same repository three weeks
ago, so no shipped or in-tree frontend references them. Verified by an
exhaustive scan, not by grep of a single directory.
terminate_running_evaluators_sync()is gone from theshutdown path. If any user still has an orphaned evaluator process from a
build predating this change, it will no longer be reaped at app exit. Those
processes are Docker/CLI children of a feature that has had no UI entry point
since 2026-08-16, so the practical exposure is nil.
restore must re-run
cargo checkrather than assume it still compiles.git mvand revert the four in-place edits (allrecorded in
.archive/README.md), or revert this commit wholesale.Verification
cargo check --workspace --all-targets— passes, 44 crates, no warningsintroduced.
cargo clippy --workspace --all-targets -- -D warnings— passes (exit 0).handler_list.incand searchedevery
.ts/.tsx/.js/.jsx/.mjs/.cjs/.json/.html/.md/.rs/.toml/.yml/.yamlfilein the repository (9,690 files, excluding
node_modules,target,.archive) for each command name. The 13benchmark_*commands have zerohits outside
handler_list.incand the module itself.invoke()call sites (
useEmbeddedWebview,diagnostics/rustBridge) both receivecommand names as constants, so no command is reachable by a constructed
string. No
benchmark_*entry appears insrc-tauri/capabilities/default.json.pnpm typecheck/vitest/Playwright were not run — this PR changes no TypeScript, and the frontend
callers were removed in a prior PR.
git worktreewhere
.husky/_/husky.shdoes not exist (gitignored, sogit worktree addnever creates it) and
node_modulesis not installed. The hook's"Pre-commit hook ran." tamper-evidence trailer is therefore always missing in
a worktree and means nothing here; the checks it would have run (
cargo clippy) were run manually and are reported above. No TypeScript is touched,so
lint-staged/tschad nothing to check.